[plugin] allow dynamic name
Bug #1475629 reported by
Jonas G. Drange
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
ubuntu-system-settings (Ubuntu) |
Fix Released
|
High
|
Jonas G. Drange |
Bug Description
Reproduce (always, trunk):
Try changing a plugin's name dynamically.
What happens:
You can't.
What should happen:
You should be able to change the name dynamically, like you can the icon, keywords and visibility.
Solution:
Add
void setDisplayName(
to existing interface which provides:
void setIcon(const QUrl &icon);
void setKeywords(const QStringList &keywords);
void setVisible(bool visible);
I do not think name of plugin should change, as this could have implications elsewhere. Only the displayName should change.
Related branches
lp:~jonas-drange/ubuntu-system-settings/has-dynamic-name
- Ken VanDine: Approve
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Sebastien Bacher (community): Approve
-
Diff: 218 lines (+73/-6)7 files modifiedlib/SystemSettings/item-base.cpp (+16/-0)
lib/SystemSettings/item-base.h (+4/-0)
src/plugin.cpp (+8/-1)
src/plugin.h (+2/-1)
tests/data/brightness.settings (+14/-0)
tests/test-plugin.cpp (+9/-3)
tests/tst_plugins.cpp (+20/-1)
Changed in ubuntu-system-settings (Ubuntu): | |
status: | Incomplete → Confirmed |
importance: | Wishlist → High |
Changed in ubuntu-system-settings (Ubuntu): | |
assignee: | nobody → Jonas G. Drange (jonas-drange) |
status: | Confirmed → In Progress |
To post a comment you must log in.
What's the usecase?