[2.20-Build 64] schema-transformer shows 'AttributeError: 'NoneType' object has no attribute 'append'

[Daisuke Nakajima]

While creating virtual-networs/virtual-machine-interface/logical-interfaces, shcema-transforer shows following traceback.

 /var/log/contrail/contrail-schema-stdout.log
Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
    result = self._run(*self.args, **self.kwargs)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3702, in launch_arc
    raise e
AttributeError: 'NoneType' object has no attribute 'append'
<Greenlet at 0x7f67bc2cd730: launch_arc(<schema_transformer.to_bgp.SchemaTransformer objec, <cfgm_common.ifmap.client.client instance at 0x7f6)> failed with AttributeError

[Hari Prasad Killi (haripk)]

schema.err had this error:

Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3683, in launch_arc
    transformer.process_poll_result(result)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3280, in process_poll_result
    func(idents, meta)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 2886, in add_security_group_entries
    sg.update_policy_entries(entries)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 1372, in update_policy_entries
    (ingress_list, egress_list) = self.policy_to_acl_rule(prule)
  File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 1434, in policy_to_acl_rule
    acl_rule_list.append(acl)
AttributeError: 'NoneType' object has no attribute 'append'

[Sachin Bansal (sbansal)]

Could you please let me know what rules had you added to the security group and how did you add them (webui, horizon, neutron or vnc api)?

[Daisuke Nakajima (dnakajima)]

I didn't set a particular security group.
I sent following JSON messages ( $ () is variable) ;

virtual-network
{"virtual-network": { "fq_name": ["default-domain", "demo", "${name}"], "flood_unknown_unicast": true, "is_shared": false, "network_ipam_refs": [{"attr": {"ipam_subnets": [{"addr_from_start": true, "allocation_pools": [], "default_gateway": "${prefix}.1", "dhcp_option_list": {"dhcp_option": []}, "dns_server_address": "${prefix}.2", "enable_dhcp": true, "host_routes": {"route": []}, "subnet": {"ip_prefix": "${prefix}.0", "ip_prefix_len": 24} }]}, "to": ["default-domain", "default-project", "default-network-ipam"]}], "parent_type": "project" ,"uuid" : "${uuid}", "virtual_network_properties": {"allow_transit": false, "forwarding_mode": "l2_l3"}}}
    [Return] ${resource}

VirtualMachineInterface
 {"virtual-machine-interface": {"fq_name": ["default-domain", "demo", "${name}"], "parent_type": "project", "security_group_refs": [{"attr": null, "to": ["default-domain", "demo", "default"]}], "uuid": "${uuid}", "virtual_machine_interface_mac_addresses": {"mac_address": ["${mac}"]}, "virtual_machine_interface_properties": {}, "virtual_network_refs": [{"attr": null, "to": ["default-domain", "demo", "${vnname}"] }]}}

logical-interface
 {"logical-interface": { "fq_name": ["default-global-system-config", "${tor}", "${pport}", "${lport}"], "parent_type": "physical-interface", "logical_interface_vlan_tag": ${vlan}, "virtual_machine_interface_refs": [{"to" : ["default-domain", "demo", "${vmi}"]}], "logical_interface_type": "l2"}}

[Sachin Bansal (sbansal)]

This is the security group that has incorrect rules:

            "security-group": {
                "configured_security_group_id": 0,
                "display_name": "permit-any",
                "fq_name": [
                    "default-domain",
                    "demo",
                    "permit-any"
                ],
                "href": "http://localhost:8095/security-group/88888888-0000-0000-0000-000000000002”,

> On Jul 15, 2015, at 5:18 PM, Daisuke Nakajima <email address hidden> wrote:
>
> I didn't set a particular security group.
> I sent following JSON messages ( $ () is variable) ;
>
> virtual-network
> {"virtual-network": { "fq_name": ["default-domain", "demo", "${name}"], "flood_unknown_unicast": true, "is_shared": false, "network_ipam_refs": [{"attr": {"ipam_subnets": [{"addr_from_start": true, "allocation_pools": [], "default_gateway": "${prefix}.1", "dhcp_option_list": {"dhcp_option": []}, "dns_server_address": "${prefix}.2", "enable_dhcp": true, "host_routes": {"route": []}, "subnet": {"ip_prefix": "${prefix}.0", "ip_prefix_len": 24} }]}, "to": ["default-domain", "default-project", "default-network-ipam"]}], "parent_type": "project" ,"uuid" : "${uuid}", "virtual_network_properties": {"allow_transit": false, "forwarding_mode": "l2_l3"}}}
> [Return] ${resource}
>
> VirtualMachineInterface
> {"virtual-machine-interface": {"fq_name": ["default-domain", "demo", "${name}"], "parent_type": "project", "security_group_refs": [{"attr": null, "to": ["default-domain", "demo", "default"]}], "uuid": "${uuid}", "virtual_machine_interface_mac_addresses": {"mac_address": ["${mac}"]}, "virtual_machine_interface_properties": {}, "virtual_network_refs": [{"attr": null, "to": ["default-domain", "demo", "${vnname}"] }]}}
>
> logical-interface
> {"logical-interface": { "fq_name": ["default-global-system-config", "${tor}", "${pport}", "${lport}"], "parent_type": "physical-interface", "logical_interface_vlan_tag": ${vlan}, "virtual_machine_interface_refs": [{"to" : ["default-domain", "demo", "${vmi}"]}], "logical_interface_type": "l2"}}
>
> --
> You received this bug notification because you are a member of Contrail
> Systems engineering, which is subscribed to Juniper Openstack.
> https://bugs.launchpad.net/bugs/1474665
>
> Title:
> [2.20-Build 64] schema-transformer shows 'AttributeError: 'NoneType'
> object has no attribute 'append'
>
> Status in Juniper Openstack:
> New
> Status in Juniper Openstack r2.20 series:
> New
>
> Bug description:
> While creating virtual-networs/virtual-machine-interface/logical-
> interfaces, shcema-transforer shows following traceback.
>
> /var/log/contrail/contrail-schema-stdout.log
> Traceback (most recent call last):
> File "/usr/lib/python2.7/dist-packages/gevent/greenlet.py", line 327, in run
> result = self._run(*self.args, **self.kwargs)
> File "/usr/lib/python2.7/dist-packages/schema_transformer/to_bgp.py", line 3702, in launch_arc
> raise e
> AttributeError: 'NoneType' object has no attribute 'append'
> <Greenlet at 0x7f67bc2cd730: launch_arc(<schema_transformer.to_bgp.SchemaTransformer objec, <cfgm_common.ifmap.client.client instance at 0x7f6)> f...

[Daisuke Nakajima (dnakajima)]

the issue is seeing after deleting all of security groups except Default.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14160
Submitter: Sachin Bansal (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14160
Committed: http://github.org/Juniper/contrail-controller/commit/5b7452b4e57343ed481ba008373d189a873b3b1d
Submitter: Zuul
Branch: master

commit 5b7452b4e57343ed481ba008373d189a873b3b1d
Author: Sachin Bansal <email address hidden>
Date: Thu Oct 1 17:20:32 2015 -0700

SG rule should be ignored if neither source or destination is 'local'

It was was earlier possible to create a security group rule without specifying
direction. Such rule cannot be applied, and hence should be ignored. We have
already added check in api server to disallow such rules, but for pre-existing
rules, adding a check in schema transforemer also.

Change-Id: If67fd89dfcd718ad45b0f51f1b069e1f55ded522
Closes-Bug: 1474665