launchpadlib

Python 3.5 test failures

Bug #1473577 reported by Barry Warsaw
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
launchpadlib
Fix Released
High
Unassigned
lazr.restfulclient
Fix Released
High
Colin Watson

Bug Description

platform.linux_distribution() -- and its alias platform.dist() -- are deprecated in Python 3.5 to be removed in Python 3.7. They are marked with PendingDeprecationWarnings, and they cause two tests to fail under Python 3.5. I'll have a simple fix that will at least get the package buildable under Python 3.5.

Tags: python3.5

Related branches

lp:~barry/launchpadlib/lp1473577
Dimitri John Ledkov: Approve
Diff: 19 lines (+2/-0)
1 file modified
src/launchpadlib/tests/test_launchpad.py (+2/-0)
lp:~cjwatson/lazr.restfulclient/lsb-release
Rejected for merging into lp:lazr.restfulclient
Colin Watson (community): Disapprove
Diff: 35 lines (+10/-7)
1 file modified
src/lazr/restfulclient/authorize/oauth.py (+10/-7)
lp:~cjwatson/lazr.restfulclient/distro
William Grant: Approve (code)
Diff: 245 lines (+50/-90)
4 files modified
setup.py (+5/-1)
src/lazr/restfulclient/authorize/oauth.py (+5/-6)
src/lazr/restfulclient/docs/NEWS.rst (+3/-0)
src/lazr/restfulclient/tests/test_oauth.py (+37/-83)
Revision history for this message
Barry Warsaw (barry) wrote :

Oh yeah, the calls are actually in lazr.restfulclient, but cause the test failures in launchpadlib.

Barry Warsaw (barry)
tags: added: python3.5
William Grant (wgrant)
Changed in launchpadlib:
status: New → Fix Committed
importance: Undecided → High
Changed in lazr.restfulclient:
status: New → Triaged
importance: Undecided → High
Changed in launchpadlib:
assignee: nobody → Dimitri John Ledkov (xnox)
Colin Watson (cjwatson)
Changed in lazr.restfulclient:
assignee: nobody → Colin Watson (cjwatson)
status: Triaged → In Progress
Dimitri John Ledkov (xnox)
Changed in launchpadlib:
assignee: Dimitri John Ledkov (xnox) → nobody
Revision history for this message
Colin Watson (cjwatson) wrote :

1.10.4 (2016-07-12)
===================
- Fix _bad_oauth_token crash on Python 3. [bug=1471894]
- Time out make_end_user_authorize_token after 15 minutes.
- Ignore PendingDeprecationWarning from lazr.restfulclient. [bug=1473577]
- Ask forgiveness rather than permission when creating cache directories.
- Fix browser token authorization on OS X. [bug=1516080]

Changed in launchpadlib:
status: Fix Committed → Fix Released
Revision history for this message
Colin Watson (cjwatson) wrote :

0.14.0 (2018-05-08)
===================

  - Switch from buildout to tox.
  - Port from oauth to oauthlib. Some tests still need to use oauth until
    lazr.authentication is ported. [bug=1672458]
  - Use the distro module rather than platform.linux_distribution, since the
    latter is deprecated in Python 3.5 and will be removed in 3.7.
    [bug=1473577]

Changed in lazr.restfulclient:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.