tests fail on python3.5
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Next Generation Checkbox (CLI) |
Fix Released
|
Critical
|
Zygmunt Krynicki | ||
checkbox-ng (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
I got a ping from Barry Warsaw about a bit of our code breaking in Python 3.5:
The link (if you don't see it anymore) is showing this failure:
FAIL: test_help (commands.
-------
Traceback (most recent call last):
File "/«PKGBUILDDIR»
self.
AssertionError: "/«BUILDDIR»
- /«PKGBUILDDIR»
- sig = Signature.
usage: checkbox sru [-h] [--check-config] --secure-id SECURE-ID
optional arguments:
-h, --help show this help message and exit
--check-config run check-config before starting
sru-specific options:
--secure-id SECURE-ID
--fallback FILE if submission fails save the test report as FILE
--destination URL POST the test report XML to this URL (https:/
--staging override --destination to use the staging
execution options:
-n, --dry-run don't really run most jobs
test selection options:
-T TEST-PLAN-ID, --test-plan TEST-PLAN-ID
-i PATTERN, --include-pattern PATTERN
-x PATTERN, --exclude-pattern PATTERN
-w WHITELIST, --whitelist WHITELIST
I think we can do some simple checks for python version or, if we can, just kill checkbox-ng's dbus support.
Related branches
Changed in checkbox-ng: | |
assignee: | nobody → Zygmunt Krynicki (zyga) |
Changed in checkbox-ng: | |
status: | Confirmed → Fix Committed |
Changed in checkbox-ng: | |
status: | Fix Committed → Fix Released |
A couple of quick other thoughts.
You could just suppress the DeprecationWarning, or you could use Signature. from_callable( ) when that API is available (i.e. do an attribute check first).
Either way, thanks for looking into this!