Allow custom override of Chartjs graph defaults

Bug #1472889 reported by Robert Lyon
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Wishlist
Robert Lyon
15.10
Fix Released
Undecided
Unassigned

Bug Description

Need to override the graph defaults so that we can use a custom tool tip template.

There will be 2 patches:

1) Allowing the passing in of custom graph options

2) Updating tooltip template for some graphs

I plan to put the allowing to choose custom options in the object passed to fetch_graph_data rather than in the graph functions themselves - this way the same saved graph data can be used with different custom settings.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4940

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4941

Revision history for this message
Jinelle Foley-Barnes (jinelleb) wrote :

Hi,

Can I have some test instruction for these patches please.

Thank you,
Jinelle

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4940
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/eb205d6d492ff0e164b60dac8f93d4e0be7d8002
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit eb205d6d492ff0e164b60dac8f93d4e0be7d8002
Author: Robert Lyon <email address hidden>
Date: Thu Jul 9 16:19:31 2015 +1200

Bug 1472889: Allowing override of global chart settings

Change-Id: If629c70bfe1c8d0d36dbe9a284a58ad2734da753
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4941
Committed: https://git.nzoss.org.nz/mahara/mahara/commit/346c57e4b3f5d948358b8597269001e7e45dad9f
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit 346c57e4b3f5d948358b8597269001e7e45dad9f
Author: Robert Lyon <email address hidden>
Date: Thu Jul 9 16:44:17 2015 +1200

Bug 1472889: Adjustments to some of the stats graphs

1) Allowing the labels for the institutions graph be on mouseover

2) Restrict the number of items on graph to be 12 instead of 25

3) Allowing the weekly stats be line graphs

4) Allowing the template to override the colours for stored graph jsondata

Change-Id: Ie0b157fa1493755383b5207bc77e7b35ba140c7a
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.