Replace /Forwarded/Fwd/

[sander]

When I forward a message, the tittle starts with "Forwarded: ". This should be "Fwd: " as is common in the email world.

[Mats (matsben)]

I guess you meant the subject line. Then there is also a prefix text to the forwarded message which is not translatable.

[sander (s-devrieze)]

You mean this?:

Forwarded message from written at 20071004T12:30:51
 --------------------------------------------------------------------

Some feedback about this (some items also apply for the Reply action):
* Should be translatable
* time should be in a human readable format (also localized, see another bug)
* nickname is missing

Also, I would suggest to do it similar to email software.

So, for a reply add this text:
On date, Full Name <contact ID> wrote:

This can be:
On 10/04/07, MSN User <email address hidden> wrote:

For a forward this can be:
---------- Forwarded message ----------
From: Full Name <contact ID>
Date: 4 oct. 2007 12:45
Subject: The subject of the original message

[Mats (matsben)]

Added a few more fixes to format Reply and Forward messages.

[sander (s-devrieze)]

This is how it looks on my computer (From field still empty! Maybe
because the business card of my test account is not complete?):

---------- Forwarded message ----------
From: <>
Date: do 04 okt 2007 17:20:33 CEST
Subject: test

test

[Mats (matsben)]

I get:

---------- Forwarded message ----------
Från: mari@localhost/Psi <mari@localhost/Psi>
Datum: Mon Oct 30 10:25:43 2006
Ämne:

hcsdlhcfsddk

It could be that I am having metakit support and you don't.
Will check this.

/Mats

On 10/4/07, sander <email address hidden> wrote:
> This is how it looks on my computer (From field still empty! Maybe
> because the business card of my test account is not complete?):
>
> ---------- Forwarded message ----------
> From: <>
> Date: do 04 okt 2007 17:20:33 CEST
> Subject: test
>
> test
>
> --
> Replace /Forwarded/Fwd/
> https://bugs.launchpad.net/bugs/147236
> You received this bug notification because you are a bug assignee.
>

[Mats (matsben)]

Tested without Metakit and that works by me. Note sure what happened.

[sander (s-devrieze)]

Maybe it is a bug in the Google Talk service? Or maybe because there is no name set in the business card? Or maybe because the local name I set for this contact is too long? See attachment for the bug.

[Mats (matsben)]

Ahhhh... that dialog. Missing -from switch. Untested.

On 10/9/07, sander <email address hidden> wrote:
> Maybe it is a bug in the Google Talk service? Or maybe because there is
> no name set in the business card? Or maybe because the local name I set
> for this contact is too long? See attachment for the bug.
>
> ** Attachment added: "forwarded-bug.png"
> http://launchpadlibrarian.net/9896054/forwarded-bug.png
>
> --
> Replace /Forwarded/Fwd/
> https://bugs.launchpad.net/bugs/147236
> You received this bug notification because you are a bug assignee.
>

[sander (s-devrieze)]

2007/10/9, Mats <email address hidden>:
> Ahhhh... that dialog. Missing -from switch. Untested.

Still 1 bug:
"From: <email address hidden>/Psi <<email address hidden>/Psi>" should be:
"From: langetest1234567890testnogeenkeertje12345 <<email address hidden>/Psi>"

--
Mvg, Sander Devrieze.

[Mats (matsben)]

The logic looks like this:

 set name [::Roster::GetShortName $from]
 set origSubject [string map {"Fwd: " ""} $opts(-subject)]

 $wtext insert end "---------- "
 $wtext insert end [mc "Forwarded message"]
 $wtext insert end " ----------"
 $wtext insert end "\n"
 $wtext insert end "[mc From]: $name <$from>"
 $wtext insert end "\n"
 $wtext insert end "[mc Date]: $date"
 $wtext insert end "\n"
 $wtext insert end "[mc Subject]: $origSubject"
 $wtext insert end "\n\n"
 $wtext insert end $opts(-forwardmessage)

Note that the From must refer to one and the same contact, shouldn't it?

On 10/9/07, sander <email address hidden> wrote:
> 2007/10/9, Mats <email address hidden>:
> > Ahhhh... that dialog. Missing -from switch. Untested.
>
> Still 1 bug:
> "From: <email address hidden>/Psi <<email address hidden>/Psi>" should be:
> "From: langetest1234567890testnogeenkeertje12345 <<email address hidden>/Psi>"
>
> --
> Mvg, Sander Devrieze.
>
> --
> Replace /Forwarded/Fwd/
> https://bugs.launchpad.net/bugs/147236
> You received this bug notification because you are a bug assignee.
>

[sander (s-devrieze)]

2007/10/9, Mats <email address hidden>:
> Note that the From must refer to one and the same contact, shouldn't it?

Doesn't seems so. See the screenshot; it should look like in the
"Incoming Message" window.

--
Mvg, Sander Devrieze.

[Mats (matsben)]

I can't see what is going wrong right now.

[sander (s-devrieze)]

2007/10/10, Mats <email address hidden>:
> I can't see what is going wrong right now.

Maybe because I have an empty business card on my GMail account? The
long name you see is just a local name I gave to my GMail account on
my jabber.se test account. Maybe it is related to this? Anyway, in the
one dialog it works correctly, whilst it doesn't in the other...so
there should be a bug somewhere...but you are the specialist ;-)

--
Mvg, Sander Devrieze.

[Mats (matsben)]

It doesn't look at the vcard. It is just the 'from' attribute of the
message it is forwarding, and I can't figure out why that is missing.
Could you execute
::MailBox::MKHaveMetakit
after you have opened the inbox and send 0/1 to me?

/Mats

On 10/10/07, sander <email address hidden> wrote:
> 2007/10/10, Mats <email address hidden>:
> > I can't see what is going wrong right now.
>
> Maybe because I have an empty business card on my GMail account? The
> long name you see is just a local name I gave to my GMail account on
> my jabber.se test account. Maybe it is related to this? Anyway, in the
> one dialog it works correctly, whilst it doesn't in the other...so
> there should be a bug somewhere...but you are the specialist ;-)
>
> --
> Mvg, Sander Devrieze.
>
> --
> Replace /Forwarded/Fwd/
> https://bugs.launchpad.net/bugs/147236
> You received this bug notification because you are a bug assignee.
>

[sander (s-devrieze)]

2007/10/11, Mats <email address hidden>:
> It doesn't look at the vcard. It is just the 'from' attribute of the
> message it is forwarding, and I can't figure out why that is missing.
> Could you execute
> ::MailBox::MKHaveMetakit
> after you have opened the inbox and send 0/1 to me?

0

--
Mvg, Sander Devrieze.

[sander (s-devrieze)]

2007/10/11, Sander Devrieze <email address hidden>:
> 2007/10/11, Mats <email address hidden>:
> > It doesn't look at the vcard. It is just the 'from' attribute of the
> > message it is forwarding, and I can't figure out why that is missing.
> > Could you execute
> > ::MailBox::MKHaveMetakit
> > after you have opened the inbox and send 0/1 to me?
>
> 0

I now also installed libmetakit and tried the same. Now I get:
1

But the issue remains...so I guess the bug has nothing to do with metakit!

--
Mvg, Sander Devrieze.

[Mats (matsben)]

Does this happen both Forward from Inbox and GotMsg dialogs?
Can you switch on
set debugLevel 4
in Coccinella.tcl and see what the -from switch from the following
debug print which you get from the console:
::NewMsg::Build args=...
and then do
::Roster::GetShortName $from
with $from the -from value, i.e.:
set from the-JID-in-from

On 10/11/07, sander <email address hidden> wrote:
> 2007/10/11, Sander Devrieze <email address hidden>:
> > 2007/10/11, Mats <email address hidden>:
> > > It doesn't look at the vcard. It is just the 'from' attribute of the
> > > message it is forwarding, and I can't figure out why that is missing.
> > > Could you execute
> > > ::MailBox::MKHaveMetakit
> > > after you have opened the inbox and send 0/1 to me?
> >
> > 0
>
> I now also installed libmetakit and tried the same. Now I get:
> 1
>
> But the issue remains...so I guess the bug has nothing to do with
> metakit!
>
> --
> Mvg, Sander Devrieze.
>
> --
> Replace /Forwarded/Fwd/
> https://bugs.launchpad.net/bugs/147236
> You received this bug notification because you are a bug assignee.
>

[sander (s-devrieze)]

RECV: <message <email address hidden>/Psi'
<email address hidden>' id='aab5a'>
<subject>test</subject>
<body>test</body>
<nos:x value='disabled' xmlns:nos='google:nosave'/><arc:record
otr='false' xmlns:arc='http://jabber.org/protocol/archive'/></message>
::MailBox::MessageHook bodytxt='test', args='-xmldata {message {from
<email address hidden>/Psi id aab5a to <email address hidden>} 0 {}
{{subject {} 0 test {}} {body {} 0 test {}} {x {value disabled xmlns
google:nosave} 1 {} {}} {record {otr false xmlns
http://jabber.org/protocol/archive} 1 {} {}}}} -from
<email address hidden>/Psi -id aab5a -to <email address hidden>
-subject test -body test -record {record {otr false xmlns
http://jabber.org/protocol/archive} 1 {} {}} -x {{x {value disabled
xmlns google:nosave} 1 {} {}}} -uuid
8a7be8f5-0dae-4f3a-7371-8fd87d50e34a'
GotMsg::GotMsg uid=8a7be8f5-0dae-4f3a-7371-8fd87d50e34a
::GotMsg::Show thisMsgId=8a7be8f5-0dae-4f3a-7371-8fd87d50e34a
::GotMsg::Build
::BuddyPounce::Event from = <email address hidden>, eventkey=msg
::NewMsg::Build args='-subject {Fwd: test} -forwardmessage test -time
20071014T15:26:36 -from <email address hidden>/Psi'
NewMsg::InitEach
SEND

[Mats (matsben)]

The
-from <email address hidden>/Psi
is correct so far and that should at least make the <email address hidden> correct.
I changed the from to be the bare JID. I just tested a similar situation like yours, from gmail to jabber.se, and that worked.