review tools need to be updated for systemd click compatibility hook removal
Bug #1472296 reported by
Jamie Strandboge
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Canonical Click Reviewers tools (obsolete) |
Fix Released
|
Critical
|
Jamie Strandboge | ||
| click-reviewers-tools (Ubuntu) |
Fix Released
|
Undecided
|
Jamie Strandboge | ||
Bug Description
This is blocking all snappy app uploads.
Related branches
| Changed in click-reviewers-tools: | |
| status: | Triaged → In Progress |
| Changed in click-reviewers-tools: | |
| status: | In Progress → Fix Committed |
| Changed in click-reviewers-tools: | |
| status: | Fix Committed → Fix Released |
| Changed in click-reviewers-tools (Ubuntu): | |
| assignee: | nobody → Jamie Strandboge (jdstrand) |
| status: | New → In Progress |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #1 |
| Changed in click-reviewers-tools (Ubuntu): | |
| status: | In Progress → Fix Released |
Revision history for this message
| Jamie Strandboge (jdstrand) wrote | #2 |
To post a comment you must log in.
This bug was fixed in the package click-reviewers
---------------
click-reviewers
* cr_security.py:
- webview is not required with ubuntu-
- bin-path and systemd hooks shouldn't be used any more to ascertain if an
app is a service or binary since snappy build is no longer adding them
and snappy install ignores them (LP: #1472296)
* cr_common.py: comment that snappy-systemd hook is deprecated
* cr_lint.py: comment that snappy-systemd hook is deprecated
* cr_systemd.py:
- directly parse package.yaml instead of parsing deprecated snappy-systemd
hook
- remove snappy-systemd hook checks now that it is ignored by snappy
install in stable releases
* cr_bin_path.py: remove bin-path hook checks now that it is ignored by
snappy install in stable releases
-- Jamie Strandboge <email address hidden> Tue, 07 Jul 2015 15:11:15 -0500