Upgrade script not copying etc/openstack_deploy/env.d/*

Bug #1471190 reported by Matt Thompson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack-Ansible
Fix Released
Medium
Matt Thompson
Kilo
Fix Released
Medium
Matt Thompson
Trunk
Fix Released
Medium
Matt Thompson

Bug Description

It looks like the 10->11 upgrade script is creating /etc/openstack_deploy/env.d but not copying /opt/os-ansible-deployment/etc/openstack_deploy/env.d/* to it.

Changed in openstack-ansible:
status: New → In Progress
Revision history for this message
Darren Birkett (darren-birkett) wrote :
Revision history for this message
Matt Thompson (mattt416) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (master)

Reviewed: https://review.openstack.org/198311
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=d339da31035f03e226e335be794c3ac114148430
Submitter: Jenkins
Branch: master

commit d339da31035f03e226e335be794c3ac114148430
Author: Matt Thompson <email address hidden>
Date: Fri Jul 3 12:02:47 2015 +0100

    Fix scripts/run-upgrade.sh

    Currently, scripts/run-upgrade.sh will not successfully upgrade a
    deploy from juno->kilo. This update does the following:

    - copies etc/openstack_deploy/env.d/* to /etc/openstack_deploy/env.d
    - uses ansible modules where possible rather than using the ansible
      shell module
    - forces ansible command to return true where necessary (we introduce
      new ansible host groups in kilo and these groups do not yet have
      containers built which will cause the ansible command to fail)
    - updates the python code to keep is_metal configurations between
      juno and kilo deployments (kilo defaults is_metal=true for
      cinder_volumes, which was not the default on juno)
    - moves a closing if statement higher up in the script which was
      erroneously causing a bunch of code to be skipped

    Change-Id: Ic99dcbc3f64b8dbfec6188a017a8bcda1c80e544
    Closes-Bug: #1471190
    Co-Authored-By: Kevin Carter <email address hidden>

Changed in openstack-ansible:
status: In Progress → Fix Committed
Revision history for this message
Darren Birkett (darren-birkett) wrote :
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to os-ansible-deployment (kilo)

Reviewed: https://review.openstack.org/200597
Committed: https://git.openstack.org/cgit/stackforge/os-ansible-deployment/commit/?id=93c7ae4a6687f787ab7ba797307bbe7b1b2e63cc
Submitter: Jenkins
Branch: kilo

commit 93c7ae4a6687f787ab7ba797307bbe7b1b2e63cc
Author: Matt Thompson <email address hidden>
Date: Fri Jul 3 12:02:47 2015 +0100

    Fix scripts/run-upgrade.sh

    Currently, scripts/run-upgrade.sh will not successfully upgrade a
    deploy from juno->kilo. This update does the following:

    - copies etc/openstack_deploy/env.d/* to /etc/openstack_deploy/env.d
    - uses ansible modules where possible rather than using the ansible
      shell module
    - forces ansible command to return true where necessary (we introduce
      new ansible host groups in kilo and these groups do not yet have
      containers built which will cause the ansible command to fail)
    - updates the python code to keep is_metal configurations between
      juno and kilo deployments (kilo defaults is_metal=true for
      cinder_volumes, which was not the default on juno)
    - moves a closing if statement higher up in the script which was
      erroneously causing a bunch of code to be skipped

    Change-Id: Ic99dcbc3f64b8dbfec6188a017a8bcda1c80e544
    Closes-Bug: #1471190
    Co-Authored-By: Kevin Carter <email address hidden>
    (cherry picked from commit d339da31035f03e226e335be794c3ac114148430)

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.11

This issue was fixed in the openstack/openstack-ansible 11.2.11 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/openstack-ansible 11.2.12

This issue was fixed in the openstack/openstack-ansible 11.2.12 release.

Revision history for this message
Davanum Srinivas (DIMS) (dims-v) wrote : Fix included in openstack/openstack-ansible 11.2.14

This issue was fixed in the openstack/openstack-ansible 11.2.14 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.