QFX does not handle transient duplicate VxLAN id for two different VNs

[Prabhjot Singh Sethi]

on programming duplicate VxLAN id for a transient state, QFX goes into bad state and does not recover without manual intervention.

After the config has settled (moved away from transient state), one has to go and execute "clear ovsdb commit failures" on qfx to recover.

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14080
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14109
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14539
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14539
Committed: http://github.org/Juniper/contrail-controller/commit/0dd9f57494e71ec33cc46c1fbc00208eb7523585
Submitter: Zuul
Branch: master

commit 0dd9f57494e71ec33cc46c1fbc00208eb7523585
Author: Prabhjot Singh Sethi <email address hidden>
Date: Tue Oct 20 10:49:34 2015 +0530

Adding Delete-Add event handling to KSync

Providing Delete-Add event handling in KSync State Machine
to allow trigger of Delete followed by Add for and entry
This can also be used for catastrophic change event.

Related-Bug: 1466731
Change-Id: I29d4624563af22c92000301675b5f0a7328647b3

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14724
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14852
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14724
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15114
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14724
Committed: http://github.org/Juniper/contrail-controller/commit/2139b2f00fee0abc581332b9f58b16b6bd7ca6bf
Submitter: Zuul
Branch: master

commit 2139b2f00fee0abc581332b9f58b16b6bd7ca6bf
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Oct 30 14:43:49 2015 +0530

Handle duplicate VxLan ID for two different VNs

Issue:
------
QFX doesnot handle duplicate VxLan ID for two different
VNs, since OVSDB schema doesnot consider VxLan ID as key
it ends up into commit failures on QFX

Fix:
----
- if VxLan ID for a VN is already in use avoid programming
it to QFX till it is available
- Added VxLan resource managing infra.
- UT added for the same
- TODO need to handle cyclic change in VxLAN ID

Partial-Bug: 1466731
Change-Id: I878f094e987686efb8680cb1fadb0905e5f06af7

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15114
Committed: http://github.org/Juniper/contrail-controller/commit/6324dfdb604adc5be149dab6d805931d26a51bb4
Submitter: Zuul
Branch: R2.20

commit 6324dfdb604adc5be149dab6d805931d26a51bb4
Author: Hari <email address hidden>
Date: Fri Nov 13 21:50:21 2015 +0530

Handle duplicate VxLan ID for two different VNs

Issue:
------
QFX doesnot handle duplicate VxLan ID for two different
VNs, since OVSDB schema doesnot consider VxLan ID as key
it ends up into commit failures on QFX

Fix:
----
- if VxLan ID for a VN is already in use avoid programming
it to QFX till it is available
- Added VxLan resource managing infra.
- UT added for the same
- TODO need to handle cyclic change in VxLAN ID

Partial-Bug: 1466731

Committing on behalf of Prabhjot.
Change-Id: I8c05208c788c75b2ced8eb263a5ec8cde23183d1

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/14852
Submitter: Prabhjot Singh Sethi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/14852
Committed: http://github.org/Juniper/contrail-controller/commit/4bc0e166a91287a7d17052957b90b37480925c15
Submitter: Zuul
Branch: master

commit 4bc0e166a91287a7d17052957b90b37480925c15
Author: Prabhjot Singh Sethi <email address hidden>
Date: Fri Nov 27 14:41:16 2015 +0530

Handle Cyclic change of VxLAN id for VNs

Support to handle Cyclic change of VxLAN id for VNs here
if OVSDB client fails to allocate the VxLAN id it triggers
delete of logical switch from OVSDB database and release
the old VxLAN id and breaks cyclic dependency

Closes-Bug: 1466731
Change-Id: If1e9891eaa3aac8496d4e4c2ac53405a12d09e63

[Prabhjot Singh Sethi (prabhjot)]

we will avoid pushing handling of cyclic change of VxLAN ID to R2.20 for now

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/15963
Submitter: Vedamurthy Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/15963
Committed: http://github.org/Juniper/contrail-test/commit/89d204d6ffdefc2650940fa86fc33d2f1a8323f3
Submitter: Zuul
Branch: master

commit 89d204d6ffdefc2650940fa86fc33d2f1a8323f3
Author: Vedu Joshi <email address hidden>
Date: Wed Nov 4 12:00:13 2015 +0530

Add tests for bugs 1466731, 1504710 and other minor changes

* move create_vn(), do_ping_test() and setup_vmi() to neutron base.py
* Remove the workaround due to 1466731 since it is fixed
* In lif_fixture.py, disassociate vmis always
* Bug fix to find out the right active tor agent ip
* In vm_test.py, enhance run_cmd_on_vm() to optionally return fabric’s
_AttributeString instead of returning plain output
* In vm_test.py, Add support to run arbitrary python code
* Add test test_diff_vns_but_same_vxlan_id to validate Bug 1466731
* Add test test_with_fuzz_bug_1504710 to validate bug 1504710 fix
* Accomodate change tor_id -> tor_agent_id as in bug 1506790

Conflicts:
 tcutils/util.py

Change-Id: I594dd48022bfd43a645bd597ec29519e76fcf7c9

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/16082
Submitter: Vedamurthy Joshi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/16082
Committed: http://github.org/Juniper/contrail-test/commit/17784d8cf030d694b8d276e720a0c3479ce9cf7d
Submitter: Zuul
Branch: R2.20

commit 17784d8cf030d694b8d276e720a0c3479ce9cf7d
Author: Vedu Joshi <email address hidden>
Date: Wed Nov 4 12:00:13 2015 +0530

Add tests for bugs 1466731, 1504710 and other minor changes

* move create_vn(), do_ping_test() and setup_vmi() to neutron base.py
* Remove the workaround due to 1466731 since it is fixed
* In lif_fixture.py, disassociate vmis always
* Bug fix to find out the right active tor agent ip
* In vm_test.py, enhance run_cmd_on_vm() to optionally return fabric’s
_AttributeString instead of returning plain output
* In vm_test.py, Add support to run arbitrary python code
* Add test test_diff_vns_but_same_vxlan_id to validate Bug 1466731
* Add test test_with_fuzz_bug_1504710 to validate bug 1504710 fix
* Accomodate change tor_id -> tor_agent_id as in bug 1506790

Conflicts:
 common/contrail_test_init.py
 fixtures/vm_test.py
 tcutils/util.py

Change-Id: I594dd48022bfd43a645bd597ec29519e76fcf7c9

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/18364
Submitter: Hari Prasad Killi (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/18364
Committed: http://github.org/Juniper/contrail-controller/commit/204ec2a908ffb129186e05b771bd5fabbf453ca8
Submitter: Zuul
Branch: R2.21.x

commit 204ec2a908ffb129186e05b771bd5fabbf453ca8
Author: Hari <email address hidden>
Date: Fri Nov 13 21:50:21 2015 +0530

Handle duplicate VxLan ID for two different VNs

Issue:
------
QFX doesnot handle duplicate VxLan ID for two different
VNs, since OVSDB schema doesnot consider VxLan ID as key
it ends up into commit failures on QFX

Fix:
----
- if VxLan ID for a VN is already in use avoid programming
it to QFX till it is available
- Added VxLan resource managing infra.
- UT added for the same
- TODO need to handle cyclic change in VxLAN ID

Partial-Bug: 1466731

Committing on behalf of Prabhjot.
(cherry picked from commit 6324dfdb604adc5be149dab6d805931d26a51bb4)
Change-Id: I8c05208c788c75b2ced8eb263a5ec8cde23183d1

[Prabhjot Singh Sethi (prabhjot)]

Bug-1580507 is side-effect of change for handling cyclic vxlan-id change backport of handling for cyclic vxlan change will also require fix for 1580507

[Prabhjot Singh Sethi (prabhjot)]

we will avoid pushing handling of cyclic change of VxLAN ID to R2.21.x