Possible usage of undefined variable in oslo.messaging

[Denis Meltsaykin]

This code has been found during examination of oslo.messaing's code:
impl_rabbit.py line number ~646

            except Exception as ex:
                # NOTE(comstud): Unfortunately it's possible for amqplib
                # to return an error not covered by its transport
                # connection_errors in the case of a timeout waiting for
                # a protocol response. (See paste link in LP888621)
                # So, we check all exceptions for 'timeout' in them
                # and try to reconnect in this case.
                if 'timeout' not in six.text_type(e):
                    raise
                e = ex

There is possible an error: e = ex comes after if-section, this makes if useless and always to raise an exception.

Also the bug in upstream has been filed: https://bugs.launchpad.net/oslo.messaging/+bug/1465314

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.1/2014.2
Change author: Denis V. Meltsaykin <email address hidden>
Review: https://review.fuel-infra.org/7848

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7848
Submitter: Oleksii Zamiatin <email address hidden>
Branch: openstack-ci/fuel-6.1/2014.2

Commit: 4e11d9d036cae1aff0317b27282b495a9dc1ae09
Author: Denis V. Meltsaykin <email address hidden>
Date: Mon Jun 15 15:48:37 2015

Fix possible usage of undefined variable

Fix variable defenition in Connection.reconnect() as this could lead
to undefined behavior.

Change-Id: Ifb22d6884964faa5d8a76dcaafef5c79b6e9ee47
Closes-Bug: #1465300

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-6.0-updates/2014.2
Change author: Denis V. Meltsaykin <email address hidden>
Review: https://review.fuel-infra.org/7860

[Fuel Devops McRobotson (fuel-devops-robot)]

Reviewed: https://review.fuel-infra.org/7860
Submitter: mos-infra-ci <>
Branch: openstack-ci/fuel-6.0-updates/2014.2

Commit: 1015995820a07f164f0c2cbe3abab955399abb50
Author: Denis V. Meltsaykin <email address hidden>
Date: Mon Jun 15 16:49:10 2015

Fix possible usage of undefined variable

Fix variable defenition in Connection.reconnect() as this could lead
to undefined behavior.

Change-Id: Ifb22d6884964faa5d8a76dcaafef5c79b6e9ee47
Closes-Bug: #1465300
(cherry picked from commit 4e11d9d036cae1aff0317b27282b495a9dc1ae09)

[Fuel Devops McRobotson (fuel-devops-robot)]

Fix proposed to branch: openstack-ci/fuel-7.0/2015.1.0
Change author: Denis V. Meltsaykin <email address hidden>
Review: https://review.fuel-infra.org/8286

[Fuel Devops McRobotson (fuel-devops-robot)]

Change abandoned by Victor Sergeyev <email address hidden> on branch: openstack-ci/fuel-7.0/2015.1.0
Review: https://review.fuel-infra.org/8286
Reason: This code was refactored during the Kilo release cycle

[Denis Meltsaykin (dmeltsaykin)]

Roman, could you please explain why you added customer-found tag? I haven't ever heard that some one has faced the issue. We don't even know what is the real impact.