2015-06-15 14:03:51 |
Denis Meltsaykin |
bug |
|
|
added bug |
2015-06-15 14:09:50 |
Alexey Khivin |
mos: assignee |
|
Denis Meltsaykin (dmeltsaykin) |
|
2015-06-15 15:04:05 |
Alexey Khivin |
mos: status |
New |
In Progress |
|
2015-06-15 15:04:18 |
Alexey Khivin |
mos: milestone |
|
6.1 |
|
2015-06-15 16:47:48 |
Denis Meltsaykin |
nominated for series |
|
mos/6.0-updates |
|
2015-06-15 16:47:48 |
Denis Meltsaykin |
bug task added |
|
mos/6.0-updates |
|
2015-06-15 16:47:57 |
Denis Meltsaykin |
mos/6.0-updates: assignee |
|
Denis Meltsaykin (dmeltsaykin) |
|
2015-06-15 16:47:59 |
Denis Meltsaykin |
mos/6.0-updates: milestone |
|
6.0-mu-4 |
|
2015-06-15 16:48:53 |
Denis Meltsaykin |
mos: status |
In Progress |
Fix Committed |
|
2015-06-15 16:48:56 |
Denis Meltsaykin |
mos/6.0-updates: status |
New |
In Progress |
|
2015-06-15 16:59:46 |
Denis Meltsaykin |
description |
This code has been found during examination of oslo.messaing's code:
impl_rabbit.py line number ~646
except Exception as ex:
# NOTE(comstud): Unfortunately it's possible for amqplib
# to return an error not covered by its transport
# connection_errors in the case of a timeout waiting for
# a protocol response. (See paste link in LP888621)
# So, we check all exceptions for 'timeout' in them
# and try to reconnect in this case.
if 'timeout' not in six.text_type(e):
raise
e = ex
There is possible an error: e = ex comes after if-section, this makes if useless and always to raise exception . |
This code has been found during examination of oslo.messaing's code:
impl_rabbit.py line number ~646
except Exception as ex:
# NOTE(comstud): Unfortunately it's possible for amqplib
# to return an error not covered by its transport
# connection_errors in the case of a timeout waiting for
# a protocol response. (See paste link in LP888621)
# So, we check all exceptions for 'timeout' in them
# and try to reconnect in this case.
if 'timeout' not in six.text_type(e):
raise
e = ex
There is possible an error: e = ex comes after if-section, this makes if useless and always to raise an exception.
Also the bug in upstream has been filed: https://bugs.launchpad.net/oslo.messaging/+bug/1465314 |
|
2015-06-16 15:35:47 |
Dmitry Mescheryakov |
mos: importance |
Undecided |
Medium |
|
2015-06-16 15:35:49 |
Dmitry Mescheryakov |
mos/6.0-updates: importance |
Undecided |
Medium |
|
2015-06-22 13:08:15 |
Denis Meltsaykin |
mos/6.0-updates: status |
In Progress |
Fix Committed |
|
2015-06-26 10:48:34 |
Olena Logvinova |
tags |
oslo.messaging |
done oslo.messaging release-notes |
|
2015-06-26 17:31:38 |
Vitaly Sedelnik |
mos/6.0-updates: status |
Fix Committed |
Fix Released |
|
2015-09-16 23:52:30 |
Roman Rufanov |
tags |
done oslo.messaging release-notes |
customer-found done oslo.messaging release-notes support |
|
2015-09-26 13:23:16 |
Vitaly Sedelnik |
nominated for series |
|
mos/6.0.x |
|
2015-09-26 13:23:16 |
Vitaly Sedelnik |
bug task added |
|
mos/6.0.x |
|
2015-09-26 13:23:21 |
Vitaly Sedelnik |
mos/6.0.x: status |
New |
Fix Released |
|
2015-09-26 13:23:23 |
Vitaly Sedelnik |
mos/6.0.x: importance |
Undecided |
Medium |
|
2015-09-26 13:23:33 |
Vitaly Sedelnik |
mos/6.0.x: assignee |
|
Denis Meltsaykin (dmeltsaykin) |
|
2015-09-26 13:23:39 |
Vitaly Sedelnik |
mos/6.0.x: milestone |
|
6.0-mu-4 |
|
2015-11-23 16:26:31 |
Denis Meltsaykin |
mos: status |
Fix Committed |
Fix Released |
|