multiple / in settings files path

[Sébastien BLAISOT]

To access files that reside in preference folder settingsPath, we usually append "/filename" to settingsPath.

settingsPath ends with a trailing "/" so this results in double "/" in the file's pathname.

this ends up with messages like this one in the logs: Main]: ConfigObject: Could not read "/home/daniel/.mixxx//mixxx.cfg"

we should get rid of double "/"

[Uwe Klotz (uklotzde-deactivatedaccount)]

I've seen many occurrences of manual file path construction in the Mixxx code base. Instead QDir::filePath()/absoluteFilePath() should be used that eliminates all redundant path separators.

One example from cmdlineargs.h:
   QDir::homePath().append("/").append(SETTINGS_PATH)
should be replaced by
   QDir::home().absoluteFilePath(SETTINGS_PATH)
which is safer and simpler.

Looks like no one is reading their Qt API docs thoroughly ;) Composition of file paths should never be done using low-level string concatenation.

[Sébastien BLAISOT (sblaisot)]

https://github.com/mixxxdj/mixxx/pull/624

[Sébastien BLAISOT (sblaisot)]

can someone change milestone to 1.12 in this bug please. thx.

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8099