Murano migrations failed due to mysql driver was updated in devstack

Bug #1464271 reported by Ekaterina Chernova
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Kirill Zaitsev

Bug Description

After fix https://github.com/openstack-dev/devstack/commit/1e6b33377f4f6dd82a65070da0ac811fae3bd905 in devstack,
murano migrations failed

Need to adopt this in murano

Tags: gate
Changed in murano:
importance: Undecided → High
status: New → Confirmed
assignee: nobody → Ekaterina Chernova (efedorova)
milestone: none → liberty-1
summary: - Murano migrations failed due to mysql driver was updated
+ Murano migrations failed due to mysql driver was updated in devstack
Revision history for this message
Ekaterina Chernova (efedorova) wrote :

The problem is more complicated, that we expected

We do support SQLite migrations. that why we do have this function to support 'alter' in sqlite:

https://github.com/openstack/murano/blob/master/murano/db/migration/alembic_migrations/versions/004_change_package_desc_type.py#L39

After switching to pymysql, force ignoring of foreign keys in Mysql is not working, so it's not possible to drop the table in transform_table functions.

We can drop sqlite support and use alter in this migration.

Changed in murano:
importance: High → Critical
Changed in murano:
assignee: Ekaterina Chernova (efedorova) → Kirill Zaitsev (kzaitsev)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/190870

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/190870
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=508739984da3740d8d2fe1acb84ebce88688c7f1
Submitter: Jenkins
Branch: master

commit 508739984da3740d8d2fe1acb84ebce88688c7f1
Author: Kirill Zaitsev <email address hidden>
Date: Fri Jun 12 02:51:16 2015 +0300

    Migrations: ignore mysql fk cheks for any mysql driver

    Before mysql migrations disabled foreign key checks only for
    mysql+mysqldb engine. Currently mysql+pymysql is preferred engine. This
    change disables FK checks for any mysql engine available.

    Change-Id: I536480559260c4be11b6e615c0df8f012798be9d
    Closes-Bug: #1464271

Changed in murano:
status: In Progress → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
status: Fix Released → Fix Committed
Changed in murano:
status: Fix Committed → Fix Released
Changed in murano:
milestone: liberty-1 → 1.0.0
Changed in murano:
milestone: 1.0.0 → 1.0.1
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.