Move Server Manager CLI to Cliff Framework
Affects | Status | Importance | Assigned to | Milestone | ||
---|---|---|---|---|---|---|
Juniper Openstack | Status tracked in Trunk | |||||
R2.20 |
Fix Released
|
Medium
|
Nitish Krishna Kaveri | |||
R3.0 |
Fix Released
|
Medium
|
Nitish Krishna Kaveri | |||
R3.1 |
Fix Released
|
Medium
|
Nitish Krishna Kaveri | |||
Trunk |
Fix Released
|
Medium
|
Nitish Krishna Kaveri |
Bug Description
Server Manager CLI needs to be Standardized using the Cliff Framework.
This Task Item is part of the quench project.
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #1 |
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #2 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #3 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #4 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #5 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #6 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #8 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #9 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #10 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #11 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit 2154a3a95c74112
Author: root <root@1404-
Date: Mon Sep 14 22:41:31 2015 +0000
Related-Bug: #1463208 - Moving Server Manager Client CLI to Cliff Framework
This check-in:
- Added main Cliff framework files
- Added Server Manager commands
- Added setup.py for cliff client pip installable package
- Packaging scripts in separate checkin
Patch 2:
- Changed bash completion to new path
Patch 3:
- Implemented review comments
- Add command substantially changed
- Discarded bash autocompletion
- Env variable smgr_ip and port can be sourced from /etc/contrail/
Patch 4:
- Added edit command
- Multiple bug fixes
- Tested all commands except upload_image
- Moved common functions to smgr_client_utils from smgr_client_def
Change-Id: I5b9fac1474fba5
OpenContrail Admin (ci-admin-f) wrote : | #12 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit ae01d832d6371e9
Author: root <root@1404-
Date: Mon Sep 14 22:41:31 2015 +0000
Related-Bug: #1463208 - Moving Server Manager Client CLI to Cliff Framework
This check-in:
- Added main Cliff framework files
- Added Server Manager commands
- Added setup.py for cliff client pip installable package
- Packaging scripts in separate checkin
Patch 2:
- Changed bash completion to new path
Patch 3:
- Implemented review comments
- Add command substantially changed
- Discarded bash autocompletion
- Env variable smgr_ip and port can be sourced from /etc/contrail/
Patch 4:
- Added edit command
- Multiple bug fixes
- Tested all commands except upload_image
- Moved common functions to smgr_client_utils from smgr_client_def
Change-Id: I5b9fac1474fba5
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #13 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #14 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #15 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #16 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #17 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #18 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #19 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit 9b3fe54dac5dad4
Author: nitishkrishna <email address hidden>
Date: Tue Sep 22 22:05:14 2015 +0000
Related-Bug: #1463208 - Changing Cliff code to match version 1.5.4
The debian package of cliff available in trusty repos is 1.5.4
The code was previously written for cliff version 1.10
This commit rolls back and rewrites smgr cli app code to reflect that
Some changes made to config files to match packaging script changes
Patch 2:
Removed pip from setup script
Modified POST call to allow match keys for run_inventory
Change-Id: Ie8af3bd7b428a3
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #20 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #21 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit ea0ac961be84ed3
Author: nitishkrishna <email address hidden>
Date: Tue Sep 22 22:05:14 2015 +0000
Related-Bug: #1463208 - Changing Cliff code to match version 1.5.4
The debian package of cliff available in trusty repos is 1.5.4
The code was previously written for cliff version 1.10
This commit rolls back and rewrites smgr cli app code to reflect that
Some changes made to config files to match packaging script changes
Patch 2:
Removed pip from setup script
Modified POST call to allow match keys for run_inventory
Change-Id: Ie8af3bd7b428a3
OpenContrail Admin (ci-admin-f) wrote : | #22 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit 6329be423db322f
Author: nitishkrishna <email address hidden>
Date: Wed Jul 15 15:21:08 2015 -0700
Related-Bug: #1463208 - Moving Server Manager Client CLI to Cliff Framework
This check-in:
- Added packaging scripts
- Packaging pip installable .tar.gz package
- Packaging additional wrapper debian for above .tar.gz
Patch 2:
- Added scripts to package with server-
- Debian can be installed with or without installer
- Setup script changes to include cliff client
Patch 3:
- Fixed the wrong Makefile to match mainline
Change-Id: I275416207e090f
OpenContrail Admin (ci-admin-f) wrote : | #23 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit 0b570f02c777442
Author: nitishkrishna <email address hidden>
Date: Wed Jul 15 15:21:08 2015 -0700
Related-Bug: #1463208 - Moving Server Manager Client CLI to Cliff Framework
This check-in:
- Added packaging scripts
- Packaging pip installable .tar.gz package
- Packaging additional wrapper debian for above .tar.gz
Patch 2:
- Added scripts to package with server-
- Debian can be installed with or without installer
- Setup script changes to include cliff client
Change-Id: I275416207e090f
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #24 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #26 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #28 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit 8a880bb99b3a42a
Author: nitishkrishna <email address hidden>
Date: Fri Oct 2 11:16:16 2015 -0700
Closes-Bug: #1463208 - Cliff minor bugs and enhancements
Bug Fixes:
- Display Cmd Error Handling
- Defaults file not found on VMs
- Edit Cmd Roles sent as string not list
Enhancements:
- Object Dict centralized
- Reimage Provision image/package autocompletion
- Select command values in table
- Default smgr_ip, smgr_port taken from ini file if missing from OS environ
Change-Id: I1d391367c0ed29
OpenContrail Admin (ci-admin-f) wrote : | #29 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit 635e31d7e4a2817
Author: nitishkrishna <email address hidden>
Date: Fri Oct 2 11:16:16 2015 -0700
Closes-Bug: #1463208 - Cliff minor bugs and enhancements
Bug Fixes:
- Display Cmd Error Handling
- Defaults file not found on VMs
- Edit Cmd Roles sent as string not list
Enhancements:
- Object Dict centralized
- Reimage Provision image/package autocompletion
- Select command values in table
- Default smgr_ip, smgr_port taken from ini file if missing from OS environ
Change-Id: I1d391367c0ed29
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #30 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #31 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #32 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit ee8b619bfdcd110
Author: nitishkrishna <email address hidden>
Date: Thu Oct 8 20:11:55 2015 -0700
Related-Bug: #1463208 - Bug fixes for Cliff Client based on Testing [1]
This check-in has bug fixes for following bugs filed by Ritam:
- From SM client cli expansion/options don’t show up after ‘delete/display server -<tab>’ or ‘delete/display server --<tab>’.
- Server-
- Where clause doesn’t work for cluster deletion, same issue as no 5 above.
- In case of empty list display I see SM client cli and shell throwing a error “list index out of range”. Don’t see this happening when I use the -d option.
- Server-
- Mac id or id mandatory for modify
- Add tag/ Update tag (server-
- Add server <enter> asks to specify the id to edit the object. Please change the message to say specify id to add the object.
- Add server --id <server_id> <tab> does not show the parameters.
- I feel these parameters should not be made mandatory. Without these server addition fails. cluster_id, password
Additional features:
- (server-
- While in the cli shell on a tab it shows all the available command options like display add delete etc. There should be a mention of q/quit/exit as the shell exit option as well.
- tab-completion of image/package in reimage/provision command - name comes after option given: reimage/provision --cluster_id abc [TAB] : shows image_id/package_id respectively.
Change-Id: I5727ced3b4e6e9
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #33 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #34 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #35 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit ad08ab38daeaa66
Author: nitishkrishna <email address hidden>
Date: Wed Nov 4 20:47:41 2015 -0800
Related-Bug: #1463208 - Adding Cliff Client to Icehouse Builds also
Missing package config for 14.04 icehouse to add Cliff Client Package to Smgr Installer
Change-Id: I4b74f4dcb62e7b
OpenContrail Admin (ci-admin-f) wrote : [Review update] master | #36 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.22-dev | #37 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : | #38 |
Review in progress for https:/
Submitter: Nitish Krishna Kaveri (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #39 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit 945005e8a5d778f
Author: nitishkrishna <email address hidden>
Date: Wed Nov 4 20:47:41 2015 -0800
Related-Bug: #1463208 - Adding Cliff Client to Icehouse Builds also
Missing package config for 14.04 icehouse to add Cliff Client Package to Smgr Installer
Change-Id: I4b74f4dcb62e7b
OpenContrail Admin (ci-admin-f) wrote : [Review update] R2.20 | #40 |
Review in progress for https:/
Submitter: Nagendra Prasath (<email address hidden>)
OpenContrail Admin (ci-admin-f) wrote : A change has been merged | #41 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: master
commit 2609a3166ac431b
Author: nitishkrishna <email address hidden>
Date: Thu Nov 5 07:05:10 2015 +0000
Related-Bug: #1463208 - Bug fixes for Cliff Client based on Testing [2]
This checkin has the following changes:
- Upload image options in CLI
- Image defaults added to ini
- Removing unnecessary mandatory options
- Bug fix: import defaults from ini
- Add server roles as list in json
- Remove template options
- Remove unused image types
- Extending timeout to 40 secs
- Bug Fix: Displaying response as table
- Remove image edit
- Bug Fix: Restart Server match keys
- Server Status in table
- Upload image - Add Category (Related-Bug: #1508296)
- Upload image fixed
- Display columns added
- Delete using where clause fixed
Change-Id: I78c72edd35cf55
OpenContrail Admin (ci-admin-f) wrote : | #42 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.20
commit 7d8d435891f2350
Author: Prasad Miriyala <email address hidden>
Date: Tue Aug 25 11:27:47 2015 -0700
port smlite related changes from R2.22-dev to R2.20
Closes-Bug: 1513743
This is a combination of 21 commits.
-------
The first commit's message is:
Partial-Bug: #1488259 smlite changes for packaging changes
- Add server manager lite deb packaging changes
- Modify setup.sh to include server manager lite option
- Add provision shell script to install server manager, create server manager objects and issue provision
- Pre check/config for testbey.py specified servers for a cluster
- Local repo pinning changes
Change-Id: I45b4cf957a4c1f
(cherry picked from commit 2d45ba3e72322c7
This is the 2nd commit message:
-------
Related-Bug: #1488259
Bug introduced by preceding merge to R2.22-dev.
The package libpython2.
Bug seen: the version 2.7.6-8ubuntu0.2 is not in precise repos
Smgr install on Ubuntu12.04 fails.
Change-Id: I3a7c212af4e091
(cherry picked from commit 4a7fbecee4bb276
This is the 3rd commit message:
-------
Related-Bug: #1488259 - Simplifying setup script and moving configuration to Post Install
Bulk of the changes made in setup script for server manager has been moved to Post install script of various packages
Some packages added as dependencies in control files
Rules files changes to prevent same files being overwritten with each install
Remaining: Some packages are still being installed explicitly -> cobbler, puppetmaster-
These packages have to be added to server-manager local repo
Patch 2:
Server Manager Install shows minimal outputs on console
named.template and named.conf.options are now manual config steps
Puppet agent certs are moved and not deleted on fresh install
Other review comments implemented
Patch 3:
Found bug in the name of sendmail and ntp conf samples being copied
Patch 4:
set +e, set -e for a grep bug in puppet cert generate
service restart for sm lite moved from postinst to setup script
Change-Id: If871e843d0f9ef
(cherry picked from commit 2ff50b696a446e9
This is the 4th commit message:
-------
updates for sm-lite packages - use interface_setup.py from client package
Closes-Bug: 1490779
Change-Id: I6b9b17d3113e58
(cherry picked from commit 89d7c936695bd3b
This is the 5th commit message:
-------
Related-Bug: #1488259 - Package xmltodict missing from SMlite and SMgr install
The package x...
OpenContrail Admin (ci-admin-f) wrote : | #43 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit d0cb087e5d676b5
Author: nitishkrishna <email address hidden>
Date: Thu Oct 8 20:11:55 2015 -0700
Related-Bug: #1463208 - Bug fixes for Cliff Client based on Testing [1]
This check-in has bug fixes for following bugs filed by Ritam:
- From SM client cli expansion/options don’t show up after ‘delete/display server -<tab>’ or ‘delete/display server --<tab>’.
- Server-
- Where clause doesn’t work for cluster deletion, same issue as no 5 above.
- In case of empty list display I see SM client cli and shell throwing a error “list index out of range”. Don’t see this happening when I use the -d option.
- Server-
- Mac id or id mandatory for modify
- Add tag/ Update tag (server-
- Add server <enter> asks to specify the id to edit the object. Please change the message to say specify id to add the object.
- Add server --id <server_id> <tab> does not show the parameters.
- I feel these parameters should not be made mandatory. Without these server addition fails. cluster_id, password
Additional features:
- (server-
- While in the cli shell on a tab it shows all the available command options like display add delete etc. There should be a mention of q/quit/exit as the shell exit option as well.
- tab-completion of image/package in reimage/provision command - name comes after option given: reimage/provision --cluster_id abc [TAB] : shows image_id/package_id respectively.
Change-Id: I5727ced3b4e6e9
OpenContrail Admin (ci-admin-f) wrote : | #44 |
Reviewed: https:/
Committed: http://
Submitter: Zuul
Branch: R2.22-dev
commit 466bae6186585ba
Author: nitishkrishna <email address hidden>
Date: Thu Nov 5 07:05:10 2015 +0000
Related-Bug: #1463208 - Bug fixes for Cliff Client based on Testing [2]
This checkin has the following changes:
- Upload image options in CLI
- Image defaults added to ini
- Removing unnecessary mandatory options
- Bug fix: import defaults from ini
- Add server roles as list in json
- Remove template options
- Remove unused image types
- Extending timeout to 40 secs
- Bug Fix: Displaying response as table
- Remove image edit
- Bug Fix: Restart Server match keys
- Server Status in table
- Upload image - Add Category (Related-Bug: #1508296)
- Upload image fixed
- Display columns added
- Delete using where clause fixed
Change-Id: Id25a561ec3132a
OpenContrail Admin (ci-admin-f) wrote : [Bug update] | #45 |
bug update...
Review in progress for https:/ /review. opencontrail. org/12428
Submitter: Nitish Krishna Kaveri (<email address hidden>)