Fuel CLI uses global proxy settings for access to Nailgun

[Dennis Dmitriev]

If one set global proxy on Fuel admin node, for example:

export http_proxy=http://10.109.20.1:3128/

, then Fuel CLI won't access to Nailgun, because it will use proxy for this action: "ERROR: The requested URL could not be retrieved", details here: http://paste.openstack.org/show/244364/

Global proxy setting is required for accessing repositories in cases when Internet allowed only through proxy from customer's admin network.

[Vladimir Kuklin (vkuklin)]

folks, just add new variable called 'repo_http_proxy' and use it for repo proxying and the other one for FUEL CLI

[Dennis Dmitriev (ddmitriev)]

Will it be used in fuel-createmirror for making local repositories?

[Ihor Kalnytskyi (ikalnytskyi)]

Agree with Vova, the case is invalid, since it's ok that the fuelclient uses http_proxy variable. If we won't to use custom proxy for repo mirroring then there should be a way to specify it only for this script.

[Roman Prykhodchenko (romcheg)]

Actually the bug is kind of valid: there should be proxy settings to cover more scenarios but I really doubt that it's a High one.

[Vitaly Parakhin (vparakhin)]

We should consider setting the "no_proxy" environment variable - and its value should include master node IP address, i.e.

export no_proxy="localhost,127.0.0.1,localaddress,.localdomain.com,10.20.0.2"

[Dmitry Pyzhov (dpyzhov)]

I've created bug #1460072 for possible options

[Dmitry Pyzhov (dpyzhov)]

Roman, what fix are you going to contribute. As I see we should improve our documentation for usage of http_proxy environment variable.

[Roman Prykhodchenko (romcheg)]

@Dmitry: actually Vitaly suggested the solution that should be applied. It's not only the client which may experience this problem. There is a need to set up no_proxy variable to prevent a lot of different problems with different utils.

[OpenStack Infra (hudson-openstack)]

Change abandoned by Roman Prykhodchenko (<email address hidden>) on branch: master
Review: https://review.openstack.org/186691
Reason: This patch is supressed

[Dmitry Pyzhov (dpyzhov)]

Fix is here: https://review.openstack.org/#/c/197918/

[OpenStack Infra (hudson-openstack)]

Related fix proposed to branch: master
Review: https://review.openstack.org/230345

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/230345
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=7b387ec229084410ddc79bd10655115b239a9244
Submitter: Jenkins
Branch: master

commit 7b387ec229084410ddc79bd10655115b239a9244
Author: Roman Prykhodchenko <email address hidden>
Date: Fri Oct 2 09:17:21 2015 +0200

    Use requests-mock for old tests

    In order to be able to change HTTP client easily
    tests must not mock requests module themselves but
    use requests-mock instead.

    Since ols CLI is going to be removed there is no need in
    creating a common base test class. This patch separates
    base classes for old and new tests and utilizes requests-mock
    for mocking HTTP client properly.

    Change-Id: Ia0996cb07e6622306f7b9e2350d9e56344004e61
    Related-bug: #1459964

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/197918
Committed: https://git.openstack.org/cgit/stackforge/python-fuelclient/commit/?id=501f8fb17462cebe689195089e1332cd2d98c8dc
Submitter: Jenkins
Branch: master

commit 501f8fb17462cebe689195089e1332cd2d98c8dc
Author: Roman Prykhodchenko <email address hidden>
Date: Fri Oct 2 16:34:40 2015 +0200

    Use session to send HTTP requests

    requests.Session brings the following benefits which
    are not easily available by invoking requests.request():

     * Connection pooling
     * Common place for configuring all requests
     * Configurable auth mechanism for the future use

    This patch also introduces HTTP_TIMEOUT and HTTP_PROXY
    configuration options which are used to set the appropriate
    requests' parameters

    Closes-bug: #1459964
    Change-Id: Iaee70768a3790a7a25c047aba2d19a058facda21

[Sebastian Kalinowski (prmtl)]

As patch https://review.openstack.org/230345 was a part of this bug and it makes more mess than it fixes, this bug have to be reopen.

[Roman Prykhodchenko (romcheg)]

@Sebastian: could you please clarify, why this bug has to be re-opened? The patch you've mentioned, was a necessary refactoring for being able to change anything in HTTP client w/o touching tests in the future. The patch https://review.openstack.org/#/c/197918 that allowed to set custom proxy server is in place and so this bug is not valid.

[Roman Prykhodchenko (romcheg)]

@Sebastian, I analyzed the feedback you left on review and it looks like it is not related to this bug. Check this one https://bugs.launchpad.net/fuel/+bug/1507512

[Sebastian Kalinowski (prmtl)]

It's related in a way that this change introduced new bugs and without reopening this bug it might took months to fix a bug introduced here.

[Artem Hrechanychenko (agrechanichenko)]

Verified on RC2

[root@nailgun ~]# ifconfig |grep enp0s3
enp0s3: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
[root@nailgun ~]# ifconfig enp0s3
enp0s3: flags=4163<UP,BROADCAST,RUNNING,MULTICAST> mtu 1500
        inet 10.109.10.2 netmask 255.255.255.0 broadcast 10.109.10.255
        inet6 fe80::662e:60ff:fe80:30 prefixlen 64 scopeid 0x20<link>
        ether 64:2e:60:80:00:30 txqueuelen 1000 (Ethernet)
        RX packets 4447016 bytes 2261103415 (2.1 GiB)
        RX errors 0 dropped 40 overruns 0 frame 0
        TX packets 7363406 bytes 7566236025 (7.0 GiB)
        TX errors 0 dropped 0 overruns 0 carrier 0 collisions 0

[root@nailgun ~]# export http_proxy=http://10.109.20.1:3128/
[root@nailgun ~]# fuel node
Can't connect to Nailgun server!
Please check connection settings in your configuration file.

[Roman Prykhodchenko (romcheg)]

Did you try to set up proxy in fuelclient's configuration?

[Roman Prykhodchenko (romcheg)]

https://github.com/openstack/python-fuelclient/blob/master/fuelclient/fuel_client.yaml

settings are case-sensitive

[Roman Prykhodchenko (romcheg)]

@Artem Grechanichenko: Do you have any comments?