Fuel Client does unexpected HTTP requests

[Roman Prykhodchenko]

Unit tests in Fuel Client mock the entire requests library allowing all requests to pass. If that mock is removed, tests detect some unexpected HTTP calls and fail. Either unexpected requests must be eliminated or tests must be fixed.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/236870

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/236870
Committed: https://git.openstack.org/cgit/openstack/python-fuelclient/commit/?id=3975398ea980c4ab3786c043843dfaaf97b4404a
Submitter: Jenkins
Branch: master

commit 3975398ea980c4ab3786c043843dfaaf97b4404a
Author: Roman Prykhodchenko <email address hidden>
Date: Mon Oct 19 11:42:09 2015 +0200

    Check unexpected HTTP calls

    requests-mock looks for any unexpected HTTP calls and marks
    tests as failed, if found any. This patch removes mocks from
    the entire requests library in order to not miss any unexpected
    requests.

    Closes-bug: #1507512
    Change-Id: I5f1458e583a3c5e8363d4ada0cdd9527258f0f0c

[Vladimir (vushakov)]

Verified on Fuel 8.0 build.

  2015.1.0-8.0:
    VERSION:
      api: '1.0'
      astute_sha: 959b06c5ef8143125efd1727d350c050a922eb12
      build_id: '147'
      build_number: '147'
      feature_groups:
      - mirantis
      fuel-agent_sha: 07560a9fc3ce5301ace04d2d3e5d68db6ee4f8d5
      fuel-createmirror_sha: d3949f3094248b9686a4c20caea5ae13c9738a8d
      fuel-library_sha: a94bddc9ae6198510402a42ad78699cb9d70fda8
      fuel-nailgun-agent_sha: 00b4b11553c250f22c0079fb74c8b782dcb7b740
      fuel-nailgun_sha: fe7fe7d082b4045d34e9b2d9aac6766dbd6cd576
      fuel-ostf_sha: f771e23c5cbecbbb578ee4574ae2e51aa2e91819
      fuel-upgrade_sha: 1e894e26d4e1423a9b0d66abd6a79505f4175ff6
      fuelmain_sha: 3b64b95f6b513b0d46b57525a858eea7a9809da3
      fuelmenu_sha: f40c3ec0e0e1bdc499f4cb50d46aecefb4dbb7c7
      network-checker_sha: a57e1d69acb5e765eb22cab0251c589cd76f51da
      openstack_version: 2015.1.0-8.0
      production: docker
      python-fuelclient_sha: a88bc94b562ee511eb277183d0a750a1e3312662
      release: '8.0'
      shotgun_sha: 25dd78a3118267e3616df0727ce746e7dead2d67