Withdraw stored analysis if the track sample count changes

Bug #1457746 reported by Daniel Schürmann
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Mixxx
Confirmed
Medium
Unassigned

Bug Description

This may happen if the track was cut or in case of seek decoding issues (still in 1.12 alpha).
Currently the waveform does not fit to the samples and the sync feature will fail is such a case.

Tags: easy waveform
Changed in mixxx:
importance: Undecided → Medium
milestone: none → 1.12.0
tags: added: easy waveform
Revision history for this message
joe (joseph-chilcott) wrote :

Hi, I am new to the Mixxx project and as thought I would try and tackle this as my first bug. Would I be able to get more information on this bug and how to replicate it? When you refer to stored analysis, is this the pre-view wave form that appears after dragging a track onto one of the decks?

Thanks,
Joe

Revision history for this message
Daniel Schürmann (daschuer) wrote :

Thank you for offering you help.

Reproduce:
* play a track in Mixxx
* close Mixxx
* cut some samples from the beginning of the track (using e.g. Audacity)
* Play this track again

What happens:
Beatgrid and waveform have an offset, (still match the old track)

What should happen:
Mixxx should detect this and reanalyze the track.

I think the same will happen if you replace the track with a completely different one.

Todo:
* setup a powerful development environment.
* Analyse why it happens.
* I think we have already some code to detect some of these situation in Library scanner. Check how this can interact with this issue.
* Propose a solution.
* Code it.

This will help to start:
http://www.mixxx.org/wiki/doku.php/bugfix_workflow

And ... Ask, if you get stucked.

Revision history for this message
joe (joseph-chilcott) wrote :

Hi Daniel,

Many thanks for the information. Just one thing, when you say 'close Mixxx' do you mean minimise mixxx or exit mixxx? The reason I ask is, mixxx does not seem to retain a previous session once closed. If I do close mixxx and then reload the edited track, the waveform is updated and represents the edited version of the track. Sorry if this is a newbie question :)

Revision history for this message
Daniel Schürmann (daschuer) wrote :

I mean: Exit Mixxx.

I have just tested this:
I have started Mixxx, played Two tracks, closed Mixxx, switched the names from the tracks.
After restart. The first track contains the audio from the second track and vice verse. The waveform is not reanalysed.

Revision history for this message
Ferran Pujol (ferranpujol) wrote :

Would this work?

1-Store in the database the last time when Mixxx modified a track file.
2-When the track is loaded, compare the database last modified time with the OS last modified time. If Mixxx is not the last app to modify the track, re-analyze it.

Revision history for this message
joe (joseph-chilcott) wrote : Re: [Bug 1457746] Re: Withdraw stored analysis if the track sample count changes

Hi Ferran,

Have you been able to replicate this issue, I am still having problems.
When I restart Mixxx, it never remembers what I have cued up on either
deck. Therefore I do not see this problem as I am forced to reload the
track each time. This could be a newbie thing (I have looked through the
mixxx documentation and config but could not see anything that would help.

If you were able to to replicate this issue can you tell me what the Git
commit ID was that you are building against when you see this issue? (
*Daniel- can you tell me the Git commit ID that you are also building
against when you see this issue?)*
I cannot comment in much depth on the solution you have proposed, however
it seems reasonable. Would this solution work if the user loaded a track
in mixxx, minimized Mixxx, edited the track and then maximized Mixxx again?

Many thanks,
Joe

On Thu, Jul 30, 2015 at 7:06 PM, Ferran Pujol <email address hidden>
wrote:

> Would this work?
>
> 1-Store in the database the last time when Mixxx modified a track file.
> 2-When the track is loaded, compare the database last modified time with
> the OS last modified time. If Mixxx is not the last app to modify the
> track, re-analyze it.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1457746
>
> Title:
> Withdraw stored analysis if the track sample count changes
>
> Status in Mixxx:
> New
>
> Bug description:
> This may happen if the track was cut or in case of seek decoding issues
> (still in 1.12 alpha).
> Currently the waveform does not fit to the samples and the sync feature
> will fail is such a case.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1457746/+subscriptions
>

Owen Williams (ywwg)
Changed in mixxx:
status: New → Confirmed
Changed in mixxx:
milestone: 2.0.0 → none
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8053

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.