Mixxx uninstall doesn't remove controller files (win)

[Sébastien BLAISOT]

When uninstalling Mixxx 1.12 (with control pannel -> programs -> uninstall), the controller files (xml + js) are not removed.

The C:\programs\Mixxx\controller directory is not removed.

I think this should be corrected before 1.12 release or we will have problem on 1.12 to next release when it will be available.

[Sébastien BLAISOT (sblaisot)]

Ok, I'm taking this one, it's easy.

[RJ Skerry-Ryan (rryan)]

Hang on -- this is currently intended behavior since we don't want to
delete user files and we don't have a way to tell if they modified the
built in ones. A proper fix isn't that easy since we should compare the
files to known untouched hashes.

On Fri, May 22, 2015, 9:05 AM Sébastien BLAISOT <email address hidden>
wrote:

> Ok, I'm taking this one, it's easy.
>
> ** Changed in: mixxx
> Assignee: (unassigned) => Sébastien BLAISOT (sblaisot)
>
> ** Changed in: mixxx
> Status: New => In Progress
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1457624
>
> Title:
> Mixxx uninstall doesn't remove controller files (win)
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1457624/+subscriptions
>

[Sébastien BLAISOT (sblaisot)]

Well, not really.

for now on, some (77) controller files are deletes (regardless if they were modified or not) and some (100) are left untouched.

I can't see any serious reason to delete some of them and not others.

Before intelligent removal is implemented, either we should delete all of them, or none, but I can't see no good reason in current behaviour.

[Sébastien BLAISOT (sblaisot)]

We should be consistant across platforms.

Are controller files marked as config files in deb for linux ?
how does it actually work on mac ?

[Sébastien BLAISOT (sblaisot)]

Are you sure that modified files kept will not be overwritten on next installation ? I can't see in NSIS script any directive to protect modified files from being overwritten on next install or upgrade.

[RJ Skerry-Ryan (rryan)]

Hm, no you're right. Sorry about that -- I was mis-remembering and when I left my comment I was away from my laptop for a week :).

Since we already delete some of them we should indeed delete all of them until we can go with a smarter solution.

On OSX the problem doesn't really exist because OS X Bundles don't let the user poke around in the application's directory and there is no installer/uninstaller.

[Sébastien BLAISOT (sblaisot)]

ok, so I'm taking this one to delete all files on uninstall

[Sébastien BLAISOT (sblaisot)]

Pull request added : https://github.com/mixxxdj/mixxx/pull/603

[Swiftb0y (swiftb0y)]

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/8043