KeyError: 'encrypted_param_names' in heat.objects.raw_template.get_by_id()

[Jason Dunsmore]

If a Heat engine is started with old data (prior to the encrypted hidden params patch), it will result in the following traceback:

2015-05-19 10:57:28.830 4524 CRITICAL heat-engine [req-6511d7ed-cd86-473b-80e8-574c172c1fac - -] KeyError: 'encrypted_param_names'
2015-05-19 10:57:28.830 4524 TRACE heat-engine Traceback (most recent call last):
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/bin/heat-engine", line 78, in <module>
2015-05-19 10:57:28.830 4524 TRACE heat-engine srv.create_periodic_tasks()
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/osprofiler/profiler.py", line 105, in wrapper
2015-05-19 10:57:28.830 4524 TRACE heat-engine return f(*args, **kwargs)
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/engine/service.py", line 320, in create_periodic_tasks
2015-05-19 10:57:28.830 4524 TRACE heat-engine show_hidden=True)
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/objects/stack.py", line 119, in get_all
2015-05-19 10:57:28.830 4524 TRACE heat-engine db_stacks)
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/objects/stack.py", line 118, in <lambda>
2015-05-19 10:57:28.830 4524 TRACE heat-engine db_stack),
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/objects/stack.py", line 70, in _from_db_object
2015-05-19 10:57:28.830 4524 TRACE heat-engine context, db_stack['raw_template_id']))
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/objects/raw_template.py", line 66, in get_by_id
2015-05-19 10:57:28.830 4524 TRACE heat-engine raw_template = cls._from_db_object(context, cls(), raw_template_db)
2015-05-19 10:57:28.830 4524 TRACE heat-engine File "/opt/heat/lib/python2.7/site-packages/heat/objects/raw_template.py", line 51, in _from_db_object
2015-05-19 10:57:28.830 4524 TRACE heat-engine encrypted_param_names = tpl.environment[env_fmt.ENCRYPTED_PARAM_NAMES]
2015-05-19 10:57:28.830 4524 TRACE heat-engine KeyError: 'encrypted_param_names'

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/184321

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/184321
Committed: https://git.openstack.org/cgit/openstack/heat/commit/?id=22e4a84cf23658917a6e05913fc53c497f09eb8e
Submitter: Jenkins
Branch: master

commit 22e4a84cf23658917a6e05913fc53c497f09eb8e
Author: Jason Dunsmore <email address hidden>
Date: Tue May 19 14:50:55 2015 -0500

    Check for encrypted_param_names key in environment

    If unencrypted data exists in the database, there will be no
    'encrypted_param_names' key in the environment. Check for this key
    before referencing it.

    Change-Id: Ie8c593818a64d150e815487e1449a52173f1ab5d
    Closes-Bug: #1456700