pt-mysql-summary is missing the "--ask-pass" option

[Jean Weisbuch]

All the other Percona Toolkit tools that are connecting to a MySQL server have the "--ask-pass" option which is a good practice when the password for the requested user is not available in "~/.my.cnf".

It probably hasnt been implemented yet as its the only shell script that does connect to a MySQL server while the others are in Perl so there is no direct copy/paste to do but it shouldnt be an issue to implement, I could do it if required.

[Frank Cizmich (frank-cizmich)]

Hello Jean,

Thanks for pointing this out!
Will be available in next release.
I've attached a patch. Check it out if you have time and see if it fits your needs.
There are shorter ways to do this but this one is supposedly POSIX compliant.

[Frank Cizmich (frank-cizmich)]

Jean,

Please ignore previous patch and use this one.

[Jean Weisbuch (m-jea0-p)]

The fix seems to be correct but i would add quotes around the $GIVEN_PASS variable at line 500 to avoid problems if the password has spaces or other control characters (and do the same at line 502).

[Shahriyar Rzayev (rzayev-sehriyar)]

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PT-684