set-context-property not dual-SIM capable, uses 0-based indexing
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Canonical System Image |
Fix Released
|
High
|
Unassigned | ||
ofono (Ubuntu) |
Fix Released
|
High
|
Tony Espy |
Bug Description
The ofono script 'set-context-
The usage of the script is:
Usage: set-context-
The first issue is that <context> is an numeric argument and is 0-based index instead of a 1-based index like most of the other scripts.
The second issue is that it actually attempts to apply the specified property/value to each modem it finds. If both modems have a context which matches the given index, then the property will be set for each.
Finally, as there's no way to specify which modem that context belongs, so it's all or nothing.
This is being reported against the version of ofono as of vivid's release:
1.12.bzr6894+
Related branches
- Alfonso Sanchez-Beato: Approve
- PS Jenkins bot: Approve (continuous-integration)
-
Diff: 1621 lines (+900/-245)19 files modifiedMakefile.am (+3/-0)
debian/changelog (+32/-0)
doc/connman-api.txt (+11/-0)
drivers/qcommsimmodem/qcom_msim_constants.h (+27/-0)
drivers/rilmodem/sim.c (+195/-31)
drivers/rilmodem/vendor.h (+2/-1)
gril/grilreply.c (+33/-0)
gril/grilreply.h (+3/-0)
gril/grilrequest.c (+44/-0)
gril/grilrequest.h (+10/-0)
plugins/qcom-msim.c (+76/-0)
plugins/ubuntu-apndb.c (+4/-2)
src/gprs.c (+229/-133)
test/create-ia-context (+0/-47)
test/list-modems (+46/-1)
test/reset-contexts (+20/-0)
test/set-context-property (+63/-30)
unit/test-grilreply.c (+56/-0)
unit/test-grilrequest.c (+46/-0)
Changed in ofono (Ubuntu): | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Tony Espy (awe) |
Changed in ofono (Ubuntu): | |
status: | Confirmed → In Progress |
Changed in canonical-devices-system-image: | |
importance: | Undecided → High |
milestone: | none → ww22-2015 |
status: | New → In Progress |
Changed in canonical-devices-system-image: | |
status: | In Progress → Fix Released |
The following pull-request fixes this bug:
https:/ /github. com/rilmodem/ ofono/pull/ 184