Property "instance.disable_terminate" is always "False" and never actually used.
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
OpenStack Compute (nova) |
In Progress
|
Low
|
Khushbuparakh |
Bug Description
The property "instance.
disable_terminate = Column(Boolean(), default=False)
in \nova\db\
This property is then used in
1) compute\api:
def _delete(self, context, instance, delete_type, cb, **instance_attrs):
if instance.
return
2) nova\api\ec2.py:
def _format_
Since there are no API provided to modify this property, it is always "False".
There are two ways to fix this:
1) Add methods to modify this property in servers/create api and servers/update api
to make it actually functional.
2) Remove this property and the whole logic in _delete().
modify nova\api\ec2.py, set result[
description: | updated |
Changed in nova: | |
assignee: | Zhenyu Zheng (zhengzhenyu) → nobody |
status: | In Progress → Confirmed |
Changed in nova: | |
assignee: | nobody → Zhenyu Zheng (zhengzhenyu) |
Changed in nova: | |
assignee: | Zhenyu Zheng (zhengzhenyu) → Marianne Linhares Monteiro (mariannelinharesm) |
Changed in nova: | |
assignee: | Marianne Linhares Monteiro (mariannelinharesm) → nobody |
Changed in nova: | |
assignee: | nobody → Sivasathurappan Radhakrishnan (siva-radhakrishnan) |
Changed in nova: | |
assignee: | Sivasathurappan Radhakrishnan (siva-radhakrishnan) → Noopur Shukla (noops.27) |
Changed in nova: | |
assignee: | Noopur Shukla (noops.27) → nobody |
Changed in nova: | |
assignee: | nobody → Khushbuparakh (khushbuparakh) |
Fix proposed to branch: master /review. openstack. org/182953
Review: https:/