Activity log for bug #1454515

Date Who What changed Old value New value Message
2015-05-13 06:52:14 Zhenyu Zheng bug added bug
2015-05-13 06:54:06 Zhenyu Zheng description The property "instance.disable_terminate" is initialized using: disable_terminate = Column(Boolean(), default=False) in \nova\db\sqlalchemy\models.py This property is then used in 1) compute\api: def _delete(self, context, instance, delete_type, cb, **instance_attrs): if instance.disable_terminate: LOG.info(_LI('instance termination disabled'), instance=instance) return 2) nova\api\ec2.py: def _format_attr_disable_api_termination(instance, result): result['disableApiTermination'] = instance.disable_terminate Since there are no API provided to modify this property, it is always "False". There are two ways to fix this: 1) Add methods to modify this property in servers/create api and servers/update api to make it actually functional. 2) Remove this property and modify nova\api\ec2.py, set result['disableApiTermination'] = False The property "instance.disable_terminate" is initialized using: disable_terminate = Column(Boolean(), default=False) in \nova\db\sqlalchemy\models.py This property is then used in 1) compute\api: def _delete(self, context, instance, delete_type, cb, **instance_attrs): if instance.disable_terminate: LOG.info(_LI('instance termination disabled'), instance=instance) return 2) nova\api\ec2.py: def _format_attr_disable_api_termination(instance, result): result['disableApiTermination'] = instance.disable_terminate Since there are no API provided to modify this property, it is always "False". There are two ways to fix this: 1) Add methods to modify this property in servers/create api and servers/update api to make it actually functional. 2) Remove this property and the whole logic in _delete(). modify nova\api\ec2.py, set result['disableApiTermination'] = False
2015-05-14 07:07:13 OpenStack Infra nova: status New In Progress
2015-05-14 07:07:13 OpenStack Infra nova: assignee Zhenyu Zheng (zhengzhenyu)
2016-03-07 12:28:24 Davanum Srinivas (DIMS) nova: assignee Zhenyu Zheng (zhengzhenyu)
2016-03-07 12:28:26 Davanum Srinivas (DIMS) nova: status In Progress Confirmed
2016-07-12 10:52:48 John Garbutt nova: importance Undecided Low
2016-07-12 10:53:01 John Garbutt tags low-hanging-fruit
2016-07-13 01:40:57 Zhenyu Zheng nova: assignee Zhenyu Zheng (zhengzhenyu)
2016-10-17 12:10:03 Marianne Linhares Monteiro nova: assignee Zhenyu Zheng (zhengzhenyu) Marianne Linhares Monteiro (mariannelinharesm)
2016-10-17 13:40:18 Marianne Linhares Monteiro nova: assignee Marianne Linhares Monteiro (mariannelinharesm)
2016-10-18 18:48:40 Sivasathurappan Radhakrishnan nova: assignee Sivasathurappan Radhakrishnan (siva-radhakrishnan)
2017-02-13 11:36:42 Noopur Shukla nova: assignee Sivasathurappan Radhakrishnan (siva-radhakrishnan) Noopur Shukla (noops.27)
2017-06-23 16:30:10 Sean Dague nova: assignee Noopur Shukla (noops.27)
2017-07-27 12:04:48 Khushbuparakh nova: assignee Khushbuparakh (khushbuparakh)
2017-07-29 09:12:11 OpenStack Infra nova: status Confirmed In Progress