[webapp-container] Remember SAML providers in URL patterns
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
webapps-sprint |
Fix Released
|
Medium
|
Alexandre Abreu | ||
webbrowser-app |
Invalid
|
Medium
|
Unassigned | ||
webbrowser-app (Ubuntu) |
Fix Released
|
Medium
|
Alexandre Abreu |
Bug Description
The implementation of the fix for bug 1451432 adds the SAML provider site to the list of the allowed URL patterns, so that the SAML provider's website will be opened within the webapp-container itself and not being delegated to the browser.
This is working fine, but we recently noticed that sometimes Google redirects the user to the SAML provider's website without passing the "SAMLRequest" parameter in the URL query; when that happens, the webapp container will delegate the opening of that page to the browser, since the URL is not in the allowed URL patterns.
The proposed solution is for the webapp-container to store the SAML provider's URL somewhere in a config file, and always append the contents of that file to the list of the allowed URL patterns.
Related branches
- PS Jenkins bot: Needs Fixing (continuous-integration)
- Alberto Mardegan (community): Approve
-
Diff: 289 lines (+181/-3)5 files modifiedsrc/app/webcontainer/WebApp.qml (+56/-1)
src/app/webcontainer/WebViewImplOxide.qml (+13/-2)
src/app/webcontainer/WebappContainerWebview.qml (+9/-0)
tests/autopilot/webapp_container/tests/fake_servers.py (+39/-0)
tests/autopilot/webapp_container/tests/test_saml_url_patterns.py (+64/-0)
Changed in webapps-sprint: | |
milestone: | none → sprint-9 |
Changed in webapps-sprint: | |
importance: | Undecided → Medium |
Changed in webbrowser-app: | |
importance: | Undecided → Medium |
Changed in webapps-sprint: | |
assignee: | nobody → Alberto Mardegan (mardy) |
Changed in webbrowser-app: | |
assignee: | nobody → Alberto Mardegan (mardy) |
Changed in webapps-sprint: | |
milestone: | sprint-9 → sprint-10 |
status: | New → In Progress |
Changed in webbrowser-app: | |
status: | New → In Progress |
Changed in webapps-sprint: | |
assignee: | Alberto Mardegan (mardy) → Alexandre Abreu (abreu-alexandre) |
Changed in webbrowser-app: | |
assignee: | Alberto Mardegan (mardy) → Alexandre Abreu (abreu-alexandre) |
Changed in webbrowser-app (Ubuntu): | |
status: | New → In Progress |
importance: | Undecided → Medium |
assignee: | nobody → Alexandre Abreu (abreu-alexandre) |
Changed in webbrowser-app: | |
assignee: | Alexandre Abreu (abreu-alexandre) → nobody |
status: | In Progress → Invalid |
Changed in webapps-sprint: | |
status: | In Progress → Fix Released |
This seems like a dup of https:/ /bugs.launchpad .net/webbrowser -app/+bug/ 1451432