Contrib.TrackViewer crashes with new Pseudo-Localization DLL files present

[Markus Gelbmann]

Contrib.TrackViewer.exe produces a "Contrib.TrackViewer.exe no longer works. The program needs to be closed" crash on startup (before even showing the main window) when the directory "qps-ploc" is present in the ORTS installation directory. Said subdirectory of the ORTS folder contains translation files (DLL) for the new pseudo-localization feature, and removing it from the main ORTS installation directory lets TrackVIewer load normally again.

See also this thread: http://www.elvastower.com/forums/index.php?/topic/26581-trackviewerexe-does-not-work-anymore

[Markus Gelbmann (gelbmann-markus)]

PS: If this problem also affects other Contrib programs has not been tested yet. Since some are translatable as well, however, I would assume they could also suffer from said problem.

[Markus Gelbmann (gelbmann-markus)]

PPS: After quickly re-building the localization DLL files (Update.bat in locales directory) and moving them to an install of a matching version of ORTS, TrackViewer seems to be the only Contrib program affected by this problem.

[jeroenp (j-paasschens)]

Dear all,
Trackviewer crashes in Languages.cs, in the LanguageManager constructor.
It gets the directory name (e.g. 'en' or in this case gps-ploc, and tries to GetCultureInfo() on this, assuming it is a lc (languageCode). But apparently gps-ploc is not a recognized language code.

Adding a 'try-catch' around it obviously would remove the problem. But I am not sure that is the correct way. What I do not understand, personally, is: what is this 'gps-ploc'? Is it a language code?

Best regards. Jeroen

[jeroenp (j-paasschens)]

Dear all,
I was a bit too fast in my reply. I did not yet look into the new pseudo-localization code in RunActivity. I will have a look at it tomorrow and see what was changed (this part of the code in TrackViewer was probably something I copied from somewhere else, And I just need to figure out what was changed exactly.

Best regards, Jeroen.

[jeroenp (j-paasschens)]

Dear all,
Fix committed in 3057, similar to Menu\options.cs
Jeroen.

[James Ross (twpol)]

Fix looks good, thanks!

"gps-ploc" is a valid language code but only sometimes (Windows Vista and later but you also need to enable it). :)