sosreport does not collect logs for Landscape Dedicated Server 15.01 and newer

[Bruce Tarro]

[Impact]

 * Sosreport does not collect logs (/var/log/landscape-server/*.log)
   for Landscape Dedicated Server 15.01 and newer.

   Description :
   Landscape Dedicated Server (LDS) 15.01 and newer logs are not located
   in "/var/log/landscape-server". They were previously in only
   "/var/log /landscape".

 * This will help to avoid Landscape customer to collect sosreport and "/var/log/landscape-server/*.log" separately.

[Test Case]

 * To reproduce the bug you need to run sosreport <=3.2-2 on a system running LDS 15.01 or newer..

   $ sudo /usr/bin/sosreport -a

   sosreport will generate a .tar.xz file in /tmp directory.
   If you look at this sosreport, "/var/log/landscape" will exist but "/var/log/landscape-server" won't be taken into account.

[Regression Potential]

 * None expected as the same commit is already in upstream [https://github.com/sosreport/sos]

 * The new patch has been well-tested in Wily system by different persons within Canonical support team and the sosreport/sos.html (attached to the bug) provided by the sosreport doesn't report any problem.
   The sosreport/sos.html also prove the patch works for the rest of the sosreport functionnalities.

[Other Info]

The patch detect if there is presence of /var/log/landscape/*.log files and/or /var/log/landscape-server/*.log files and collect the logs accordingly. This way the patch allow LDS <15.01 to collect the log from /var/log/landscape and >15.01 from /var/log/landscape-server.

[Original Description]

Landscape Dedicated Server (LDS) 15.01 and newer logs are now located in /var/log/landscape-server. This is part of the move towards using rsyslog[0]

1) The release of Ubuntu you are using, via 'lsb_release -rd' or System
Only Trusty and newer as that is all LDS is built to run on.

2) The version of the package you are using, via 'apt-cache policy pkgname' or by checking in Software Center
PPA version of sosreport

3) What you expected to happen
The expectation is that this log location be added(not replace) as there are other supported Landscape Dedicated Servers still using the old location (/var/log/landscape)

4) What happened instead
Logs are not collected from the new location.

Related:

[0] https://help.landscape.canonical.com/LDS/ReleaseNotes15.01

[Bryan Quigley (bryanquigley)]

https://github.com/sosreport/sos/pull/557

[Launchpad Janitor (janitor)]

Status changed to 'Confirmed' because the bug affects multiple users.

[Eric Desrochers (slashd)]

Here is the two commits that addressed this bug :

cbc968b [landscape] 15.01 moves logs files to landscape-server
b54a0f1 [landscape] Move landscape logs, add server support

[Eric Desrochers (slashd)]

I have cherry-picked the upstream commits[1] into the sosreport version 3.2.-2 for Wily[2]

[1] cbc968b and b54a0f1
[2] sosreport | 3.2-2 | wily | source, amd64, arm64, armhf, i386, powerpc, ppc64el

The .deb works as expected by collecting log files from either /var/log/landscape and/or /var/log/landscape-server

===========
Confirmation :
===========
||/ Name Version Architecture Description
ii sosreport 3.2-2ubuntu1 amd64 Set of tools to gather troubleshooting data from a system

root@lds-sosreport:/tmp/sosreport-lds-sosreport-20150806112843# ls -altr var/log/landscape*
var/log/landscape-server:
total 8
drwxrwxr-x 7 root root 4096 Aug 6 10:57 ..
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:26 appserver.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:26 usn-script.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:26 update-alerts.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:26 landscape-profiles.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:27 process-alerts.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:27 pingserver.log
drwxr-xr-x 2 root root 4096 Aug 6 11:27 .

var/log/landscape:
total 8
-rw-r--r-- 1 syslog landscape 0 Aug 6 10:06 sysinfo.log
drwxrwxr-x 7 root root 4096 Aug 6 10:57 ..
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:27 appserver.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:27 usn-script.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:28 update-alerts.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:28 landscape-profiles.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:28 process-alerts.log
-rw-r--r-- 1 syslog landscape 0 Aug 6 11:28 pingserver.log
drwxr-xr-x 2 root root 4096 Aug 6 11:28 .

I'm also attachement the sosreport/sos.html proving the landscape plugin works as expected :
Plugin landscape

Files copied:

    /var/log/landscape/process-alerts.log
    /var/log/landscape/pingserver.log
    /var/log/landscape/usn-script.log
    /etc/landscape/service.conf
    /etc/landscape/service.conf.old
    /var/log/landscape-server/appserver.log
    /etc/default/landscape-server
    /var/log/landscape-server/update-alerts.log
    /var/log/landscape/appserver.log
    /var/log/landscape-server/landscape-profiles.log
    /var/log/landscape-server/process-alerts.log
    /var/log/landscape/landscape-profiles.log
    /etc/default/landscape-client
    /var/log/landscape-server/pingserver.log
    /var/log/landscape-server/usn-script.log
    /etc/landscape/client.conf
    /var/log/landscape/sysinfo.log
    /var/log/landscape/update-alerts.log

Commands Executed:

    gpg --verify /etc/landscape/license.txt
    head -n 5 /etc/landscape/license.txt

[Eric Desrochers (slashd)]

debdiff for Wily

[Alex Moldovan (alexmoldovan)]

Package tested. It grabs the landscape-server logs.

[Ubuntu Foundations Team Bug Bot (crichton)]

The attachment "debdiff for wily (sosreport_3.2-2ubuntu1)" seems to be a debdiff. The ubuntu-sponsors team has been subscribed to the bug report so that they can review and hopefully sponsor the debdiff. If the attachment isn't a patch, please remove the "patch" flag from the attachment, remove the "patch" tag, and if you are member of the ~ubuntu-sponsors, unsubscribe the team.

[This is an automated message performed by a Launchpad user owned by ~brian-murray, for any issue please contact him.]

[Sebastien Bacher (seb128)]

Thanks, I'm going to sponsor that debdiff but the package is currently in sync with Debian and ideally should stay this way, can you forward the change to the debian BTS as well?

[Eric Desrochers (slashd)]

Hi Sebastien,

Yes, I will make sure the package stay in sync with the Debian one by forwarding the change to the Debian BTS as well.

Regards,

[Sebastien Bacher (seb128)]

https://launchpad.net/ubuntu/+source/sosreport/3.2-2ubuntu1

[Eric Desrochers (slashd)]

I have build a new version of sosreport on a PPA[1] for people to test on Trusty and provide feedbacks.

[1] https://launchpad.net/~eric-desrochers-z/+archive/ubuntu/bug1449131

Thanks !

[Bruce Tarro (cydizen)]

Tested PPA[1] - Passed on Trusty w/ 15.01. No noted regressions.

[1] https://launchpad.net/~eric-desrochers-z/+archive/ubuntu/bug1449131

[Eric Desrochers (slashd)]

debdiff for Trusty