Murano

YAQL is broken

Bug #1448990 reported by Alexander Tivelkov
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Murano
Fix Released
Critical
Alexander Tivelkov
Murano 2015.1.0 "kilo"
Kilo
Fix Released
Critical
Alexander Tivelkov
Murano 2015.1.0 "kilo"
Liberty
Fix Released
Critical
Alexander Tivelkov
Murano 1.0.1
YAQL
Fix Released
Critical
Alexander Tivelkov
Kilo
Fix Released
Critical
Alexander Tivelkov
YAQL 0.2.5
python-muranoclient
Fix Released
Critical
Kirill Zaitsev
python-muranoclient 0.6.0
Kilo
Fix Released
Critical
Kirill Zaitsev
python-muranoclient 0.5.8
Liberty
Fix Released
Critical
Kirill Zaitsev
python-muranoclient 0.6.0

Bug Description

Due to unpinned requirement on ply YAQL expression compiler has been broken since the release of ply 3.6

Need to pin the requirements in yaql to ply<=3.4.
Investigation on what is wrong with 3.6 should follow.

Alexander Tivelkov (ativelkov)
Changed in murano:
milestone: none → kilo-rc2
Serg Melikyan (smelikyan)
Changed in murano:
status: New → Confirmed
Alexander Tivelkov (ativelkov)
Changed in yaql:
importance: Undecided → Critical
status: New → Confirmed
assignee: nobody → Alexander Tivelkov (ativelkov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177742

Changed in murano:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/177743

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177811

Changed in murano:
assignee: Alexander Tivelkov (ativelkov) → Ekaterina Chernova (efedorova)
Serg Melikyan (smelikyan)
Changed in yaql:
milestone: none → 0.2.5
Changed in murano:
assignee: Ekaterina Chernova (efedorova) → Alexander Tivelkov (ativelkov)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to yaql (stable/0.2)

Reviewed: https://review.openstack.org/177729
Committed: https://git.openstack.org/cgit/stackforge/yaql/commit/?id=0ee93eb1b9f4dd8c7c4d9f6df7b23b42f5509381
Submitter: Jenkins
Branch: stable/0.2

commit 0ee93eb1b9f4dd8c7c4d9f6df7b23b42f5509381
Author: Alexander Tivelkov <email address hidden>
Date: Mon Apr 27 14:53:15 2015 +0300

    Ply version pinned to <=3.4

    Bumps yaql version to 0.2.5 at the same time.

    Change-Id: I3ec272733e4fb6b58e257989afb1b0a4020c5772
    Closes-bug: #1448990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to yaql (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177903

Changed in yaql:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to murano-dashboard (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/177932

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on yaql (master)

Change abandoned by Alexander Tivelkov (<email address hidden>) on branch: master
Review: https://review.openstack.org/177903
Reason: Seem like there is a better fix for that in master, abanding, will pin to 3.6 when the fix is implemented properly

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to yaql (master)

Fix proposed to branch: master
Review: https://review.openstack.org/177950

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (stable/kilo)

Reviewed: https://review.openstack.org/177743
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=bc9d389b5d57d1eb521d2770bff82abc8502ea6a
Submitter: Jenkins
Branch: stable/kilo

commit bc9d389b5d57d1eb521d2770bff82abc8502ea6a
Author: Alexander Tivelkov <email address hidden>
Date: Mon Apr 27 15:30:28 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been update to pin ply requirement and a new version has been
    released. This patch updates murano requirements to use this version.

    Closes-bug: #1448990
    (cherry picked from commit fbdf47eefbf2e8680704173e69aefdd6ac97e2b0)

    Change-Id: I083720156d323a999740609e8c04b963c2eca043

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (stable/kilo)

Reviewed: https://review.openstack.org/177932
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=4ea66c11b4e9ac5ef521b0f3b67a897a47e70455
Submitter: Jenkins
Branch: stable/kilo

commit 4ea66c11b4e9ac5ef521b0f3b67a897a47e70455
Author: Alexander Tivelkov <email address hidden>
Date: Mon Apr 27 22:02:48 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been update to pin ply requirement and a new version has been
    released. This patch updates murano requirements to use this version.

    Change-Id: Iabb2cd39dd08cf949d0e374a63b6b54263220ead
    Closes-bug: #1448990

Changed in murano:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano (master)

Reviewed: https://review.openstack.org/177742
Committed: https://git.openstack.org/cgit/openstack/murano/commit/?id=3a24e4d922cdeb900e8e2294d88e1cc61dcecbe8
Submitter: Jenkins
Branch: master

commit 3a24e4d922cdeb900e8e2294d88e1cc61dcecbe8
Author: Alexander Tivelkov <email address hidden>
Date: Mon Apr 27 15:23:13 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been update to pin ply requirement and a new version has been
    released. This patch updates murano requirements to use this version.

    Change-Id: I5ceb536a821977bf6c18d6a06074605eb37ff194
    Closes-bug: #1448990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to murano-dashboard (master)

Reviewed: https://review.openstack.org/177811
Committed: https://git.openstack.org/cgit/openstack/murano-dashboard/commit/?id=f255e02a7a5203908a0ec23a0e5b7eb349df36da
Submitter: Jenkins
Branch: master

commit f255e02a7a5203908a0ec23a0e5b7eb349df36da
Author: Ekaterina Chernova <email address hidden>
Date: Mon Apr 27 18:05:31 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been update to pin ply requirement and a new version has been
    released. This patch updates murano requirements to use this version.

    Change-Id: I0b9b6d051e6f8777b8c961c0e74b3dea7ed40a5a
    Closes-Bug: #1448990

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to yaql (master)

Reviewed: https://review.openstack.org/177950
Committed: https://git.openstack.org/cgit/stackforge/yaql/commit/?id=f59e459d04cc83ca99d76eebf2a4a3fef20995c3
Submitter: Jenkins
Branch: master

commit f59e459d04cc83ca99d76eebf2a4a3fef20995c3
Author: Alexander Tivelkov <email address hidden>
Date: Mon Apr 27 22:48:13 2015 +0300

    Fixed compatibility with ply 3.6

    In newly released ply 3.6 function yacc() of the yacc module no longer
    accepts 'None' as the 'tabmodule' keyword parameter and expects a valid
    string instead.
    Meanwhile, the tabmodule file is not created unless write_tables is set
    to True.

    This patchset provides such a string and ensures that it is unique.
    Omitting the 'tabmodule' parameter at all could possibly do the trick as
    well, however that would mean that the parameter would get its default
    value - 'parsetab' - which could potentially lead to a minor security
    vulnerability if the the system somehow had got a malicious 'parsetab'
    module (as yacc attempts to load the generated tables from module
    specified by 'tabmodule' before proceeding to grammar generation).
    Assigning a random value to this parameter prevents such a situation.

    This patch also fixes the ply requirement to <=3.6 to prevent future
    gate breakages due to unexpected changes in ply.

    Closes-Bug: #1448990

    Change-Id: I4364729223521864f7cda5a932503d7ce1b6fa36

Changed in yaql:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-muranoclient (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/178589

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to python-muranoclient (stable/kilo)

Related fix proposed to branch: stable/kilo
Review: https://review.openstack.org/178590

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-muranoclient (master)

Reviewed: https://review.openstack.org/178589
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=1ee951aef78a6401d3624d450e7c9a9858e15d7e
Submitter: Jenkins
Branch: master

commit 1ee951aef78a6401d3624d450e7c9a9858e15d7e
Author: Kirill Zaitsev <email address hidden>
Date: Wed Apr 29 13:08:31 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been updated to pin ply requirement and a new version has been
    released. This patch updates python-muranoclient requirements to use this version.

    Change-Id: I0104065cc22a2dd2e735c1c1ac174f0903d8aa5a
    Related-Bug: #1448990

tags: added: in-stable-kilo
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to python-muranoclient (stable/kilo)

Reviewed: https://review.openstack.org/178590
Committed: https://git.openstack.org/cgit/openstack/python-muranoclient/commit/?id=42aa976e9a87ba0f31b67d3b82708bc552c8fb23
Submitter: Jenkins
Branch: stable/kilo

commit 42aa976e9a87ba0f31b67d3b82708bc552c8fb23
Author: Kirill Zaitsev <email address hidden>
Date: Wed Apr 29 13:08:31 2015 +0300

    Updated YAQL requirement to >= 0.2.6

    YAQL has been updated to pin ply requirement and a new version has been
    released. This patch updates python-muranoclient requirements to use this version.

    Change-Id: I0104065cc22a2dd2e735c1c1ac174f0903d8aa5a
    Related-Bug: #1448990

Serg Melikyan (smelikyan)
Changed in murano:
status: Fix Committed → Fix Released
Serg Melikyan (smelikyan)
Changed in murano:
milestone: kilo-rc2 → 2015.1.0
Revision history for this message
Lakshmi Kannan (lakshmi-9) wrote :

Could you please release a 1.0.0b3 in pypi? I was trying yaql out and hit the bug fixed (tabmodule) here: https://github.com/stackforge/yaql/commit/f59e459d04cc83ca99d76eebf2a4a3fef20995c3

I would like to use 1.0. It seems to have better APIs and lot more functionality.

Revision history for this message
Alexander Tivelkov (ativelkov) wrote : Re: [Bug 1448990] Re: YAQL is broken

Hi Lakshmi,

Sorry for the delay. Beta 3 has been released on pypi. Due to some reason
(new pbr or something) the tarball on pypi has version 1.0.0.0b3 instead of
expected 1.0.0b3, but it's fully functional anyway.

--
Regards,
Alexander Tivelkov

On Fri, Jun 26, 2015 at 8:41 PM, Lakshmi Kannan <email address hidden>
wrote:

> Could you please release a 1.0.0b3 in pypi? I was trying yaql out and
> hit the bug fixed (tabmodule) here:
>
> https://github.com/stackforge/yaql/commit/f59e459d04cc83ca99d76eebf2a4a3fef20995c3
>
> I would like to use 1.0. It seems to have better APIs and lot more
> functionality.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1448990
>
> Title:
> YAQL is broken
>
> Status in Murano:
> Fix Released
> Status in murano kilo series:
> Fix Released
> Status in murano liberty series:
> Fix Released
> Status in python-muranoclient:
> Fix Released
> Status in python-muranoclient kilo series:
> Fix Released
> Status in python-muranoclient liberty series:
> Fix Released
> Status in YAQL:
> Fix Committed
> Status in YAQL kilo series:
> Fix Released
> Status in YAQL liberty series:
> Fix Committed
>
> Bug description:
> Due to unpinned requirement on ply YAQL expression compiler has been
> broken since the release of ply 3.6
>
> Need to pin the requirements in yaql to ply<=3.4.
> Investigation on what is wrong with 3.6 should follow.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/murano/+bug/1448990/+subscriptions
>

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to yaql (stable/0.2)

Fix proposed to branch: stable/0.2
Review: https://review.openstack.org/199470

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to yaql (stable/0.2)

Reviewed: https://review.openstack.org/199470
Committed: https://git.openstack.org/cgit/stackforge/yaql/commit/?id=fdcee51727a8f345aae95f9f36ed467a8dc7521d
Submitter: Jenkins
Branch: stable/0.2

commit fdcee51727a8f345aae95f9f36ed467a8dc7521d
Author: Alexander Tivelkov <email address hidden>
Date: Wed Jul 8 13:05:37 2015 +0300

    Fixed compatibility with Ply 3.6

    Ply 3.6 has changed the constraints on tabmodule variable name, it now
    may not contain dots.
    As the name of tabmodule in yaql 0.2.x is based on the grammar version it
    may include dots, thus breaking the parser.

    This patch replaces dots to underscores in tabmodule name.

    Similar issue was fixed in v1 branch by patch
    I4364729223521864f7cda5a932503d7ce1b6fa36

    Change-Id: If024e9abe7a08fd9de4c348b3df780de63c10f56
    Partial-Bug: #1448990

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.