Can't select effects in late-night on windows

Bug #1448751 reported by Max Linke
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Undecided
Owen Williams

Bug Description

build 1.12 r5387

The buttons to select a effect are missing. It works in Shade. I haven't tried it yet on linux.

Max Linke (max-linke)
Changed in mixxx:
milestone: none → 1.12.0
Revision history for this message
Owen Williams (ywwg) wrote :

Can you attach a screenshot?

Revision history for this message
Daniel Schürmann (daschuer) wrote :

This is a difference in concept.

In Shade, you have THE empty effect chain and you can put any effect to the two visible effect slots (two are hidden)
You cannot switch to other chains.
In LateNight, you switch whole chains, but you cannot edit them. Only one effect slot is visible. Mixxx has a set of predefined chains with only one slot filled.
Deere offers both method and tree effect slot per chain.

The reason for the layout in Shade was, that this is a good compromise between limited GUI Space in Shade and covered use cases. You can control two effect with on super button. The effects are statically placed into the left end right mixer bus, this allows put them on any source according to the Mixer orientation.

Revision history for this message
Owen Williams (ywwg) wrote :

This could be a font issue, I use the unicode symbols for eject and arrows, and if the font we've chosen doesn't have those codepoints on Windows that would explain it.

Revision history for this message
Max Linke (max-linke) wrote :

here is a screenshot. I can't see any buttons to switch the effect

Revision history for this message
Max Linke (max-linke) wrote :

here is the log in case that helps you

Revision history for this message
jus (jus) wrote : Re: [Bug 1448751] Can't select effects in late-night on windows

Hi,
looking at your screenshot, i see four empty effect units. Left next to the respective units ON button, you can select the previous/next CHAIN in that unit by clicking on the left/light triangle.Dark on dark, hard to see.

As Daniel pointed out, there are fundamental differences in the three skins effect rack implementation. Honestly, i`d like to see we settle for one.

The issue with the current implementation in Effect Chains is that a lot of effects are not available, that an empty chain is default, that you can not save custom Effect chains after tweaking. That would be ace.
A PR to add missing effects made it not to master, see https://github.com/mixxxdj/mixxx/pull/319 <https://github.com/mixxxdj/mixxx/pull/319>

> On Apr 27, 2015, at 8:17 AM, Max Linke <email address hidden> wrote:
>
> here is a screenshot. I can't see any buttons to switch the effect
>
> ** Attachment added: "SCREENSHOT.png"
> https://bugs.launchpad.net/mixxx/+bug/1448751/+attachment/4385283/+files/SCREENSHOT.png
>
> --
> You received this bug notification because you are a member of Mixxx
> Development Team, which is subscribed to Mixxx.
> https://bugs.launchpad.net/bugs/1448751
>
> Title:
> Can't select effects in late-night on windows
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/mixxx/+bug/1448751/+subscriptions

Revision history for this message
Max Linke (max-linke) wrote :

On 04/27/2015 11:28 AM, jus wrote:
> Dark on dark, hard to see.

Yes they are incredible hard to see on windows. They are much more
visible under linux.

> As Daniel pointed out, there are fundamental differences in the three
> skins effect rack implementation. Honestly, i`d like to see we settle
> for one.

I didn't even know we have 3 different ways to do this. I agree with you
that we should settle for one.

Revision history for this message
jus (jus) wrote :

Probably your Linux distributions gamma settings differ from Windows (gamma > 2.2).
Osx and Windows share their gamma setting of 2.2 since OS X 10.6.

Easiest would be to update the Latenight button images from dark to a bright variant.

> On Apr 27, 2015, at 12:23 PM, Max Linke <email address hidden> wrote:
>
> Yes they are incredible hard to see on windows. They are much more
> visible under linux.

Revision history for this message
Owen Williams (ywwg) wrote :

They are supposed to be bright yellow. This is just a bug.

Revision history for this message
Owen Williams (ywwg) wrote :

(and I know what the problem is now)

Revision history for this message
Owen Williams (ywwg) wrote :
Changed in mixxx:
assignee: nobody → Owen Williams (ywwg)
status: New → Fix Committed
Revision history for this message
Max Linke (max-linke) wrote : Re: [Bug 1448751] Re: Can't select effects in late-night on windows

I guess this solved it. The color is now more visible under linux. I'll
check the windows build once it is updated.

On 04/27/2015 05:23 PM, Owen Williams wrote:
> fixed
> https://github.com/mixxxdj/mixxx/commit/44accabb0cc3d96ef38e1ec51f4799c6a969412f
>
> ** Changed in: mixxx
> Assignee: (unassigned) => Owen Williams (ywwg)
>
> ** Changed in: mixxx
> Status: New => Fix Committed
>

Revision history for this message
Owen Williams (ywwg) wrote :

For posterity: I have a custom GTKRC on my machine which themes the preferences dialog and title bar, and it was also changing the colors of these objects. Without the gtkrc, the text was rendered with the user's theme's default text color.

RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/7990

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.