Search and add PageHeadStates need placeholderText

Bug #1446452 reported by Victor Thompson
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
podbird
Fix Released
Low
Nekhelesh Ramananthan

Bug Description

It'd be great if the Search (magnifier) and Add (plus) actions in the header had placeholder text. When a user selects one of the two they don't receive any assistance on what should be entered. This is mostly confusing because a user doesn't know to necessarily enter a URL when they hit the 'plus' symbol. Placeholder text would help.

Related branches

description: updated
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Thanks Victor for the bug report. It seems that the font color of the placeholder hints are too light to be noticeable in the Dark theme. They are visible while using the Light theme. I will find out how to fix this.

Changed in podbird:
status: New → Confirmed
importance: Undecided → Low
Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

@Victor, I need help on this. I am not sure why only in the dark theme, the placeholderText is not visible. I even took a look at the music app's search head state code and don't anything to modify the placeholder color. Not sure why this happens with podbird.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Nvr mind I figured it out. Some how the SDK sets the Theme.palette.normal.backgroundText to white when the dark theme is used which renders the placeholder text invisible. Not sure why this doesn't happen with the music app or may be it is overridden somewhere.

Changed in podbird:
status: Confirmed → In Progress
assignee: nobody → Nekhelesh Ramananthan (nik90)
Revision history for this message
Victor Thompson (vthompson) wrote :

@Nik, The music app overrides "Theme.palette.normal.backgroundText" to work around this. Perhaps something in podbird's dark theme can do something similar.

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

Found this code in music-app.qml,

// TODO: Workaround for pad.lv/1356779, force the theme's backgroundText color
        // to work with the app's backgroundColor
        Theme.palette.normal.backgroundText = "#81888888"

That's what I also did to fix this issue in Podbird. Pity we need such hacks still.

Revision history for this message
Victor Thompson (vthompson) wrote : Re: [Bug 1446452] Re: Search and add PageHeadStates need placeholderText

FYI, that hex value is wrong (too long) in the music app. ;)

On Wed, Apr 22, 2015 at 8:56 AM, Nekhelesh Ramananthan <
<email address hidden>> wrote:

> Found this code in music-app.qml,
>
> // TODO: Workaround for pad.lv/1356779, force the theme's backgroundText
> color
> // to work with the app's backgroundColor
> Theme.palette.normal.backgroundText = "#81888888"
>
> That's what I also did to fix this issue in Podbird. Pity we need such
> hacks still.
>
> --
> You received this bug notification because you are subscribed to the bug
> report.
> https://bugs.launchpad.net/bugs/1446452
>
> Title:
> Search and add PageHeadStates need placeholderText
>
> Status in Podbird:
> In Progress
>
> Bug description:
> It'd be great if the Search (magnifier) and Add (plus) actions in the
> header had placeholder text. When a user selects one of the two they
> don't receive any assistance on what should be entered. This is mostly
> confusing because a user doesn't know to necessarily enter a URL when
> they hit the 'plus' symbol. Placeholder text would help.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/podbird/+bug/1446452/+subscriptions
>

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

oh yeah, I normally tend to replace hex values with Ubuntu colors or proper colors names if possible and as such did not notice that it was too long.

Changed in podbird:
status: In Progress → Fix Committed
Changed in podbird:
status: Fix Committed → Fix Released
Changed in podbird:
milestone: none → 0.6
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.