Clicking ShowRouteReqIterate with an empty string causes exception

[Nischal Sheth]

Clicking ShowRouteReqIterate with an empty string as the route_info
results in an exception.

For example:,

http://10.84.13.30:8083/Snh_ShowRouteReqIterate?route_info=

Two changes should be implemented:

1. Make the control node code which parses route_info more robust
2. Don't display ShowRouteReqIterate in bgp_peer introspect main page

[Tapan Karwa (tkarwa)]

On Apr 19, 2015, at 2:07 PM, Nischal Sheth wrote:

> Private bug reported:
>
> Clicking ShowRouteReqIterate with an empty string as the route_info
> results in an exception.
>
> For example:,
>
> http://10.84.13.30:8083/Snh_ShowRouteReqIterate?route_info=
>
> Two changes should be implemented:
>
> 1. Make the control node code which parses route_info more robust
> 2. Don't display ShowRouteReqIterate in bgp_peer introspect main page
>
> ** Affects: juniperopenstack
> Importance: High
> Assignee: Tapan Karwa (tkarwa)
> Status: New
>
> ** Affects: juniperopenstack/r2.20
> Importance: High
> Assignee: Tapan Karwa (tkarwa)
> Status: New
>
> ** Affects: juniperopenstack/trunk
> Importance: High
> Assignee: Tapan Karwa (tkarwa)
> Status: New
>
>
> ** Tags: contrail-control
>
> ** Also affects: juniperopenstack/trunk
> Importance: High
> Assignee: Tapan Karwa (tkarwa)
> Status: New
>
> ** Changed in: juniperopenstack/trunk
> Milestone: None => r2.30-fcs
>
> ** Also affects: juniperopenstack/r2.20
> Importance: Undecided
> Status: New
>
> ** Changed in: juniperopenstack/r2.20
> Importance: Undecided => High
>
> ** Changed in: juniperopenstack/r2.20
> Assignee: (unassigned) => Tapan Karwa (tkarwa)
>
> ** Changed in: juniperopenstack/r2.20
> Milestone: None => r2.20-fcs
>
> --
> You received this bug notification because you are a member of Contrail
> Systems engineering, which is subscribed to Juniper Openstack.
> https://bugs.launchpad.net/bugs/1446009
>
> Title:
> Clicking ShowRouteReqIterate with an empty string causes exception
>
> Status in Juniper Openstack distribution:
> New
> Status in Juniper Openstack r2.20 series:
> New
> Status in Juniper Openstack trunk series:
> New
>
> Bug description:
> Clicking ShowRouteReqIterate with an empty string as the route_info
> results in an exception.
>
> For example:,
>
> http://10.84.13.30:8083/Snh_ShowRouteReqIterate?route_info=
>
> Two changes should be implemented:
>
> 1. Make the control node code which parses route_info more robust
> 2. Don't display ShowRouteReqIterate in bgp_peer introspect main page
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/juniperopenstack/+bug/1446009/+subscriptions

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9305
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9306
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9306
Committed: http://github.org/Juniper/contrail-controller/commit/abd407690fc57b0898b3f7d150c8896f51af53f8
Submitter: Zuul
Branch: R2.20

commit abd407690fc57b0898b3f7d150c8896f51af53f8
Author: Tapan Karwa <email address hidden>
Date: Mon Apr 20 15:40:15 2015 -0700

Changes to hide ShowRouteReqIterate from introspect

Change-Id: Id79f8a7dec6b72ec8571dd39db7552416e44f549
Partial-Bug: 1446009

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9346
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Review in progress for https://review.opencontrail.org/9347
Submitter: Tapan Karwa (<email address hidden>)

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9305
Committed: http://github.org/Juniper/contrail-controller/commit/7f2e2f4af2a4119e5c1457c26d5a1d5d8e43c0f0
Submitter: Zuul
Branch: master

commit 7f2e2f4af2a4119e5c1457c26d5a1d5d8e43c0f0
Author: Tapan Karwa <email address hidden>
Date: Mon Apr 20 15:40:15 2015 -0700

Changes to hide ShowRouteReqIterate from introspect

Change-Id: Id79f8a7dec6b72ec8571dd39db7552416e44f549
Partial-Bug: 1446009

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9346
Committed: http://github.org/Juniper/contrail-controller/commit/1dd1285aefa28724032dd2cafde4e3690879aba8
Submitter: Zuul
Branch: R2.20

commit 1dd1285aefa28724032dd2cafde4e3690879aba8
Author: Tapan Karwa <email address hidden>
Date: Tue Apr 21 15:14:19 2015 -0700

Add code to parse errors in the 'show route' backend code in the iterative request code.

Restructure the code to return empty tables in case of parse errors. The parse
errors will never happen in today's code since we hand-craft it in the code.

Change-Id: I25468b4c1050925d9e478f125536a107742bf95f
Closes-Bug: 1446009

[OpenContrail Admin (ci-admin-f)]

Reviewed: https://review.opencontrail.org/9347
Committed: http://github.org/Juniper/contrail-controller/commit/52b80e2395700d22e7d695bee1c9c928475b25d3
Submitter: Zuul
Branch: master

commit 52b80e2395700d22e7d695bee1c9c928475b25d3
Author: Tapan Karwa <email address hidden>
Date: Tue Apr 21 15:14:19 2015 -0700

Add code to parse errors in the 'show route' backend code in the iterative request code.

Restructure the code to return empty tables in case of parse errors. The parse
errors will never happen in today's code since we hand-craft it in the code.

Change-Id: I25468b4c1050925d9e478f125536a107742bf95f
Closes-Bug: 1446009