Node Event Log doesn't store the user
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| MAAS |
Fix Released
|
High
|
Jeffrey C Jones | ||
Bug Description
Node event log doesn't currently store the user under which an action was performed. This needs to be stored and displayed.
Additionally, a comment field show be added, so that for example, when a node is released, whomever released it, can post a comment of the reason for doing so.
10:37 < roaksoax-brb> sabdfl: howdy! The machine node event log will show us when the machine was released, but it won't show who did it. We have an open bug to add that information though
10:39 < sabdfl> roaksoax-brb, cool. i see stuff in maas.log, is there anything else that might be relevant?
10:39 < sabdfl> when you add the info, please capture:
10:39 < sabdfl> * the user that did it
10:40 < sabdfl> * a comment field (which a human user might just ignore but landscape might fill out)
Related branches
- Blake Rouse (community): Approve
-
Diff: 476 lines (+236/-19)3 files modifiedsrc/maasserver/api/nodes.py (+41/-13)
src/maasserver/api/tests/test_node.py (+194/-5)
src/maasserver/api/tests/test_nodes.py (+1/-1)
- Blake Rouse (community): Approve
- MAAS Maintainers: Pending requested
- Andres Rodriguez: Pending requested
-
Diff: 1438 lines (+438/-140)9 files modifiedsrc/maasserver/api/nodes.py (+4/-4)
src/maasserver/fixtures/dev_fixture.yaml (+1/-1)
src/maasserver/models/node.py (+115/-48)
src/maasserver/models/tests/test_node.py (+226/-57)
src/maasserver/node_action.py (+3/-4)
src/maasserver/rpc/nodes.py (+1/-1)
src/maasserver/tests/test_node_action.py (+14/-19)
src/metadataserver/api.py (+8/-6)
src/provisioningserver/events.py (+66/-0)
| Changed in maas: | |
| milestone: | none → 1.8.0 |
| Changed in maas: | |
| importance: | Undecided → Wishlist |
| status: | New → Triaged |
| tags: | added: trivial |
| summary: |
- Node Event Log needs to store the user + Node Event Log doesn't store the user |
| Changed in maas: | |
| milestone: | 1.8.0 → 1.9.0 |
| description: | updated |
| Changed in maas: | |
| importance: | Wishlist → High |
| description: | updated |
| description: | updated |
| Andres Rodriguez (andreserl) wrote | #1 |
| Changed in maas: | |
| assignee: | nobody → Jeffrey C Jones (trapnine) |
| Changed in maas: | |
| status: | Triaged → In Progress |
| Changed in maas: | |
| status: | In Progress → Fix Committed |
| Changed in maas: | |
| status: | Fix Committed → Fix Released |
The current Node model supports error_description, which I think it was meant to provide a description when marking machines broken. This could be renamed as action_description and could be used for any of the user driven actions / changes.