Ubuntu
qtdeclarative-opensource-src package

Backport QQuickAsyncImageProvider from upstream-dev

Bug #1439263 reported by Albert Astals Cid
70
This bug affects 3 people
Affects Status Importance Assigned to Milestone
qtdeclarative-opensource-src (Ubuntu)
Fix Released
Undecided
Timo Jyrinki
thumbnailer (Ubuntu)
Invalid
Undecided
Albert Astals Cid

Bug Description

In Qt <= 5.5 there is exactly one thread that handles loading of images that come from custom image providers, this means that if a given image provider is very slow it will block the rest of image providers.

Qt 5.6 introduces QQuickAsyncImageProvider that is a job based API that allows the custom image providers to run threads on their side, this way they won't block other requests.

By backporting QQuickAsyncImageProvider we can solve https://bugs.launchpad.net/thumbnailer/+bug/1425043 by making the thumbnailer have a "slow" thread for thumbnails that it needs to do and a "fast" one for thumbnails that are already done as shown by the proof of concept implementation at https://code.launchpad.net/~aacid/thumbnailer/asyncprovider/+merge/253188

Related branches

lp:~aacid/thumbnailer/asyncprovider
Rejected for merging into lp:thumbnailer
PS Jenkins bot (community): Needs Fixing (continuous-integration)
Unity Team: Pending requested
Diff: 722 lines (+342/-167)
13 files modified
include/thumbnailer.h (+2/-0)
plugins/Ubuntu/Thumbnailer/albumartgenerator.cpp (+86/-40)
plugins/Ubuntu/Thumbnailer/albumartgenerator.h (+7/-5)
plugins/Ubuntu/Thumbnailer/artgeneratorcommon.cpp (+1/-2)
plugins/Ubuntu/Thumbnailer/artgeneratorcommon.h (+1/-1)
plugins/Ubuntu/Thumbnailer/artistartgenerator.cpp (+87/-40)
plugins/Ubuntu/Thumbnailer/artistartgenerator.h (+8/-3)
plugins/Ubuntu/Thumbnailer/plugin.cpp (+7/-3)
plugins/Ubuntu/Thumbnailer/plugin.h (+3/-0)
plugins/Ubuntu/Thumbnailer/thumbnailgenerator.cpp (+110/-66)
plugins/Ubuntu/Thumbnailer/thumbnailgenerator.h (+10/-7)
src/libthumbnailer.map (+1/-0)
src/thumbnailer.cpp (+19/-0)
lp:ubuntu/wily/qtdeclarative-opensource-src
Revision history for this message
Michał Sawicz (saviq) wrote :

The relevant upstream change is https://codereview.qt-project.org/#/c/108540/.

Timo Jyrinki (timo-jyrinki)
Changed in qtdeclarative-opensource-src (Ubuntu):
assignee: nobody → Timo Jyrinki (timo-jyrinki)
status: New → In Progress
Changed in thumbnailer (Ubuntu):
assignee: nobody → Albert Astals Cid (aacid)
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in thumbnailer (Ubuntu):
status: New → Confirmed
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

QtDeclarative part in the overlay PPA now.

---
qtdeclarative-opensource-src (5.4.1-1ubuntu7) vivid; urgency=medium

  * debian/patches/Add-QQuickAsyncImageProvider.patch:
    - Backport QQuickAsyncImageProvider (LP: #1439263) (LP: #1425043)
  * debian/patches/Always-remove-reply-from-replies-when-processing-can.patch:
    - Drop, replaced by the new patch.

 -- Timo Jyrinki <email address hidden> Tue, 28 Apr 2015 08:50:56 +0000
---

Changed in qtdeclarative-opensource-src (Ubuntu):
status: In Progress → Fix Released
Revision history for this message
Albert Astals Cid (aacid) wrote :

Let's track the thumbnailer part in https://bugs.launchpad.net/thumbnailer/+bug/1425043

Changed in thumbnailer (Ubuntu):
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.