"Nothing to upgrade" message on 1.10 -> 15.04 upgrade

[Robert Lyon]

When upgrading from 1.10 to master the blocktype.text plugin returns 'Nothing to upgrade' as it's added as part of core upgrade.

But the 'error' icon could be confusing for sysadmins - they may think something has gone wrong with the upgrade.

Seen as we have a warning icon we might as well use it for this scenario.

I'll add a patch for this

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4543

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4548

[Aaron Wells (u-aaronw)]

I discussed with Robert, I think we should do the following:

1. Show a green icon rather than a yellow one (because there's nothing going wrong.)

2. Fix the code so that it no longer shows that "Nothing to upgrade" message for blocktype.text. I've uploaded a patch https://reviews.mahara.org/#/c/4548/ which should take care of that.

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4548
Committed: http://gitorious.org/mahara/mahara/commit/c36575dd81d61c22b1b097c937cb4373fbfd12c4
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c36575dd81d61c22b1b097c937cb4373fbfd12c4
Author: Aaron Wells <email address hidden>
Date: Tue Mar 31 17:51:31 2015 +1300

Revert "Upgrade the blocktype.text after adding 'shortcut' category"

This reverts commit f247b267231844b935b25a796c6fb77c9a299ccd.

Bug 1438475: Thanks to commit edaf831d, we no longer need to wait until
after creating the blocktype sortorder column before we install
blocktype.text.

Moving it back to its original location avoids the awkward "Nothing to
update" message seen when upgrading from 1.9 -> 15.04

Change-Id: I78c290d6d69f285fc172f76a2433546b0f7b2cb1

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4562

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4562
Committed: http://gitorious.org/mahara/mahara/commit/504bc360df00361698040984fdc6ab54abc511fd
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 504bc360df00361698040984fdc6ab54abc511fd
Author: Aaron Wells <email address hidden>
Date: Tue Mar 31 17:51:31 2015 +1300

Revert "Upgrade the blocktype.text after adding 'shortcut' category"

This reverts commit f247b267231844b935b25a796c6fb77c9a299ccd.

Bug 1438475: Thanks to commit edaf831d, we no longer need to wait until
after creating the blocktype sortorder column before we install
blocktype.text.

Moving it back to its original location avoids the awkward "Nothing to
update" message seen when upgrading from 1.9 -> 15.04

Change-Id: I78c290d6d69f285fc172f76a2433546b0f7b2cb1

[Aaron Wells (u-aaronw)]

Spinning off Bug 1445280 to handle changing the icon from red to green.