Can't download protected images

Bug #1438046 reported by Riccardo Padovani
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
webbrowser-app (Ubuntu)
Fix Released
Medium
Olivier Tilloy
webbrowser-app (Ubuntu RTM)
Fix Released
Medium
Olivier Tilloy

Bug Description

In the webbrowser app I login to a site (https://slack.com) which has private image sharing.

Under every image there is a link, named 'Open original' that links to the image itself (like https://files.slack.com/files-pri/T02A1MKNL-F046U9A6V/img_20150328_103844.jpg).

But to see the image you've to login to the website.

So, when you try to download it (long press -> save image) the browser calls the content hub, and indeed content hub saves img_20150328_103844.jpg in ~/Pictures, but the file is an .html file, and not the image, so the photo doesn't appear in the gallery app.

The first thing IMO is to display an error if the file isn't valid, because it took me a while understand what was wrong with my dowload - it says 'Success' but then my photo isn't in the gallery.

Then, there should be a way to download private resources from the web

Tags: contextmenu

Related branches

Revision history for this message
Michael Sheldon (michael-sheldon) wrote :

In the general case this is possible when downloading files, unfortunately at the moment Oxide doesn't provide a way to access cookies when using the "Save Image" context option in the web browser. They do get provided when the request for a file comes via the "downloadRequested" signal (so for example when clicking on a attachment on gmail the download will work correctly). As I recall Chris mentioned a desire to rework the context menu download stuff to happen via "downloadRequested", instead of just providing a URL, which would solve this issue.

Revision history for this message
Olivier Tilloy (osomon) wrote :

See also bug #1326070, that tracks the implementation of proper context menu support in oxide.

tags: added: contextmenu
Changed in webbrowser-app:
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Olivier Tilloy (osomon)
Changed in oxide:
assignee: nobody → Olivier Tilloy (osomon)
status: New → Confirmed
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in content-hub (Ubuntu):
status: New → Confirmed
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu RTM):
status: New → Confirmed
importance: Undecided → Medium
assignee: nobody → Olivier Tilloy (osomon)
Changed in webbrowser-app:
status: Confirmed → Invalid
assignee: Olivier Tilloy (osomon) → nobody
Revision history for this message
Olivier Tilloy (osomon) wrote :

Now that context menu support has landed in oxide (bug #1326070), link targets and media (images, video, audio, …) can be downloaded from the context menu with a call to saveLink()/saveMedia(), which will trigger the "downloadRequested" signal with the necessary data (cookies and referrer).

no longer affects: webbrowser-app
no longer affects: oxide
no longer affects: content-hub (Ubuntu)
Olivier Tilloy (osomon)
Changed in webbrowser-app (Ubuntu):
status: Confirmed → In Progress
Revision history for this message
Łukasz Zemczak (sil2100) wrote :
Download full text (14.5 KiB)

This bug was fixed in the package webbrowser-app 0.23+15.04.20150827.3-0ubuntu1 in https://launchpad.net/~ci-train-ppa-service/+archive/ubuntu/stable-phone-overlay

---------------

webbrowser-app (0.23+15.04.20150827.3-0ubuntu1) vivid; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)

webbrowser-app (0.23+15.10.20150820-0ubuntu1) wily; urgency=medium

  [ Alexandre Abreu ]
  * Fix webapp name logic (LP: #1473472)

  [ Arthur Mello ]
  * Add support for removing history entries with delete key in
    HistoryViewWide (LP: #1484562)

  [ CI Train Bot ]
  * New rebuild forced.

  [ Olivier Tilloy ]
  * Remove an old workaround for an issue that was fixed since then in
    the content hub and that caused the file picker to accept the
    selected file twice.

  [ Ugo Riboni ]
  * Merge two url utility files into one, since they had no reason for
    being separate. Add unit tests for some of the functions that had
    none.

webbrowser-app (0.23+15.10.20150817-0ubuntu1) wily; urgency=medium

  [ Arthur Mello ]
  * Make sure to set the historyModel to the HistoryView component when
    browser wide property changes (LP: #1484555)
  * Wait for OptionSelector's collapsing transition to finish (LP:
    #1484175)

  [ Colin Watson ]
  * Fix versioned dependencies on qtdeclarative5-ubuntu-ui-toolkit-
    plugin to allow qtdeclarative5-ubuntu-ui-toolkit-plugin-gles.

webbrowser-app (0.23+15.10.20150814-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Ugo Riboni ]
  * Delay the exit from fullscreen mode until focus remains lost for a
    certain amount of time. (LP: #1477308)
  * Disable find in page when the new tab view is active. (LP: #1483847)

webbrowser-app (0.23+15.10.20150813.1-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.

  [ Olivier Tilloy ]
  * Remove strong typing of the contextualActions and selectionActions
    properties. This would cause issues if an app imported Ubuntu.Web
    along with Ubuntu.Components < 1.3 and overrode one of these
    properties, because the webview expected an ActionList 1.3, and
    would get an earlier version. (LP: #1484437)
  * Update translation template.

webbrowser-app (0.23+15.10.20150812.1-0ubuntu1) wily; urgency=medium

  [ Arthur Mello ]
  * Wide screen versions of the history view and new tab view, per
    design specification. This adds a build dependency on qml-module-qt-
    labs-settings (for unit tests). (LP: #1351157, #1481647)

  [ CI Train Bot ]...

Changed in webbrowser-app (Ubuntu RTM):
status: Confirmed → Fix Released
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package webbrowser-app - 0.23+15.10.20150827.3-0ubuntu1

---------------
webbrowser-app (0.23+15.10.20150827.3-0ubuntu1) wily; urgency=medium

  [ CI Train Bot ]
  * New rebuild forced.
  * Resync trunk.

  [ Olivier Tilloy ]
  * Use the contextMenu API new in oxide 1.8. Update the visuals for the
    context menu in narrow and wide form factors. Add text editing
    commands to the context menu. Add unit and autopilot tests for the
    context menu features. This bumps the runtime dependency of webapp-
    container and qtdeclarative5-ubuntu-web-plugin on liboxideqt-
    qmlplugin to 1.8. This also removes the qtdeclarative5-ubuntu-web-
    plugin-assets binary package, which contained only one PNG asset
    which is not used anywhere any longer. (LP: #1477310, #1477315,
    #1471181, #1264493, #1487090, #1326070, #1477309, #1450430,
    #1438046)

 -- CI Train Bot <email address hidden> Thu, 27 Aug 2015 14:02:08 +0000

Changed in webbrowser-app (Ubuntu):
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.