Behat test for configuration of general settings changes.

[Jinelle Foley-Barnes]

Hi,

There is no button like "Save changes " on administration/Users/Add user/General account options.

This happens anywhere there is the General accounts option like also on the add users by CSV page.

The way that it currently saves the changes (ie turning the switches to another setting) is by popping up with a dialogue box asking if I want to leave the page or stay on the page.

I've uploaded a Behat test that this change will affect, depending if this goes ahead and if it does how the click handler is written and where the button directs you to, the test may need some vamping up.

Cheers,
Jinelle

[Mahara Bot (dev-mahara)]

Patch for "master" branch: https://reviews.mahara.org/4523

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4523
Committed: http://gitorious.org/mahara/mahara/commit/c40a0781be12abf6d917c1e31e521d1fa87c671d
Submitter: Robert Lyon (<email address hidden>)
Branch: master

commit c40a0781be12abf6d917c1e31e521d1fa87c671d
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Mar 30 13:15:13 2015 +1300

Behat Test: Switches on General account link (Bug 1431569)

The test isn't handling the way the page saves when the configuration changes are made.
An option is to add a button that saves the page Refer to Bug 1437969 for more info.

Change-Id: Ic901a8437fb1885f6bcf9c4a1c9493d2de8f1ca9

[Mahara Bot (dev-mahara)]

Patch for "15.04_STABLE" branch: https://reviews.mahara.org/4535

[Mahara Bot (dev-mahara)]

Reviewed: https://reviews.mahara.org/4535
Committed: http://gitorious.org/mahara/mahara/commit/7d67f8109687d9b79b669244aa8877edf069aa17
Submitter: Robert Lyon (<email address hidden>)
Branch: 15.04_STABLE

commit 7d67f8109687d9b79b669244aa8877edf069aa17
Author: Jinelle Foley-Barnes <email address hidden>
Date: Mon Mar 30 13:15:13 2015 +1300

Behat Test: Switches on General account link (Bug 1431569)

The test isn't handling the way the page saves when the configuration changes are made.
An option is to add a button that saves the page Refer to Bug 1437969 for more info.

Change-Id: Ic901a8437fb1885f6bcf9c4a1c9493d2de8f1ca9

[Robert Lyon (robertl-9)]

The reason there is no button like "Save changes " on administration/Users/Add user/General account options is due to it being part of the add user form, and not a form by itself.

The general account options are populated from a hard coded default set of values in function expected_account_preferences() and so never change from default when page loads - they only change for the user you are currently making.

Or in the case of upload users via csv file if you change the General account options on that page they only are different for that particular upload of the csv file.

The changes are NOT sticky.

[Jinelle Foley-Barnes (jinelleb)]

Ah, that makes sense.

Thanks Rob :)