A PIDFILE is double-defined for the corosync-notifyd init script
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
corosync (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Trusty |
Won't Fix
|
Undecided
|
Unassigned | ||
Xenial |
Won't Fix
|
Undecided
|
Unassigned | ||
Bionic |
Won't Fix
|
Wishlist
|
Miriam España Acebal | ||
Disco |
Won't Fix
|
Undecided
|
Unassigned | ||
Eoan |
Won't Fix
|
Undecided
|
Unassigned | ||
Focal |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
[SRU]
[Impact]
Users that use the sysv services provided by corosync-notifyd and corosync packages
may find a corosync-notifyd service's misfunction because it uses the pid file
created by corosync service.
[Test Plan]
In a new VM with bionic (specifically for this testing):
#Disabling systemd (this will lead you to a non-usable system at the end for other things, but
this is only for testing purposes of this bug -systemctl disable <service> didn't work-):
sudo apt remove --purge systemd
#Install corosync and corosync-notifyd:
sudo apt install corosync corosync-notifyd
#check versions (optional):
ubuntu@
ii corosync 2.4.3-0ubuntu1.2 amd64 cluster engine daemon and utilities
ii corosync-notifyd 2.4.3-0ubuntu1.2 amd64 cluster engine notification daemon
ii libcorosync-
#Start notifyd service:
ubuntu@
* Starting corosync notifying daemon corosync-notifyd [ OK ]
#Check that pid filename is not correct:
ubuntu@
/var/run/
#stop de service, check pid file is gone and install new version:
ubuntu@
* Stopping corosync notifying daemon corosync-notifyd [ OK ]
ubuntu@
ls: cannot access '/var/run/coro*': No such file or directory
ubuntu@
(Reading database ... 59514 files and directories currently installed.)
Preparing to unpack .../corosync-
Unpacking corosync-notifyd (2.4.3-0ubuntu1.3) over (2.4.3-0ubuntu1.2) ...
/var/lib/
Setting up corosync-notifyd (2.4.3-0ubuntu1.3) ...
Installing new version of config file /etc/init.
Can't exec "systemctl": No such file or directory at /usr/sbin/
/usr/sbin/
invoke-rc.d: could not determine current runlevel
invoke-rc.d: WARNING: No init system and policy-rc.d missing! Defaulting to block.
Processing triggers for dbus (1.12.2-1ubuntu1.2) ...
Processing triggers for ureadahead (0.100.0-21) ...
Processing triggers for man-db (2.8.3-2ubuntu0.1) ...
#Start notifyd service
ubuntu@
* Starting corosync notifying daemon corosync-notifyd [ OK ]
#Check pid-filename is now the same as daemon's name (corosync-notifyd):
ubuntu@
/var/run/
[Where problems could occur]
The fix is cherrypicked from the Focal's solution, only affects corosync-notifyd and
corosync services. No other services depend on this pid files. No systemd services affected.
[Other Info]
This solution follows the example of the same bug fixed in Focal at https:/
alongside bug https:/
Although the number of users affected by this is a minority, I decided to fix this
in concordance with that this issue is fixed in Focal and it's a copy/paste error
easy to understand and without impact in any other application or system.
-------
[Original Description]
A /etc/init.
> PIDFILE=
> SCRIPTNAME=
> PIDFILE=
The first one is correct and the second one is wrong as it refers to the corosync service's pidfile instead
The corosync package version is 2.3.3-1ubuntu1
Related branches
- Christian Ehrhardt (community): Approve
- Canonical Server Core Reviewers: Pending requested
- Canonical Server: Pending requested
-
Diff: 971 lines (+823/-2)22 files modifieddebian/changelog (+30/-0)
debian/control (+3/-1)
debian/corosync-notifyd.init (+0/-1)
debian/patches/series (+19/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-09f6d34a-logconfig-Remove-double-free-of-value.patch (+25/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-0c118d8f-totemknet-Check-result-of-fcntl-O_NONBLOCK-call.patch (+32/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-0c16442f-votequorum-Change-check-of-expected_votes.patch (+51/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-1fb095b0-notifyd-Check-cmap_track_add-result.patch (+50/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-29109683-totemknet-Assert-strcpy-length.patch (+44/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-35c312f8-votequorum-Assert-copied-strings-length.patch (+38/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-380b744e-totemknet-Don-t-mix-corosync-and-knet-error-codes.patch (+52/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-56ee8503-quorumtool-Assert-copied-string-length.patch (+25/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-5f543465-quorumtool-exit-on-invalid-expected-votes.patch (+33/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-624b6a47-stats-Assert-value_len-when-value-is-needed.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-74eed54a-sync-Assert-sync_callbacks.name-length.patch (+27/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-89b0d62f-stats-Check-return-code-of-stats_map_get.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-8ce65bf9-votequorum-Reflect-runtime-change-of-2Node-to-WFA.patch (+80/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-8ff7760c-cmapctl-Free-bin_value-on-error.patch (+30/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-a24cbad5-totemconfig-Initialize-warnings-variable.patch (+26/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-c631951e-icmap-icmap_init_r-leaks-if-trie_create-fails.patch (+32/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-ca320bea-votequorum-set-wfa-status-only-on-startup.patch (+67/-0)
debian/patches/ubuntu-v3.0.3-fixes/lp1869622-efe48120-totemconfig-Free-leaks-found-by-coverity.patch (+107/-0)
description: | updated |
Changed in corosync (Ubuntu): | |
status: | New → Triaged |
assignee: | nobody → Rafael David Tinoco (rafaeldtinoco) |
tags: | added: ubuntu-ha |
Changed in corosync (Ubuntu Focal): | |
assignee: | Rafael David Tinoco (rafaeldtinoco) → nobody |
Changed in corosync (Ubuntu Disco): | |
status: | New → Won't Fix |
Changed in corosync (Ubuntu Trusty): | |
status: | New → Won't Fix |
Changed in corosync (Ubuntu Eoan): | |
status: | New → Triaged |
Changed in corosync (Ubuntu Xenial): | |
status: | New → Triaged |
Changed in corosync (Ubuntu Bionic): | |
status: | New → Triaged |
tags: | added: server-triage-discuss |
tags: | removed: server-triage-discuss |
Changed in corosync (Ubuntu Bionic): | |
assignee: | nobody → Miriam España Acebal (mirespace) |
status: | Triaged → In Progress |
description: | updated |
description: | updated |
Changed in corosync (Ubuntu Bionic): | |
status: | In Progress → Won't Fix |
importance: | Low → Wishlist |
For the sysv script this still exists...