Annotation "feedback" Javascript breaks on clean-urls and sites in subdirectories
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
High
|
Aaron Wells |
Bug Description
In artefact/
However, this breaks in two scenarios:
1. If the Mahara site is in a subdirectory. For instance, my own test site sits at the URL http://
2. Clean URLs. If a site has Clean URLs turned on, then the URL to a page will be something like "https:/
So relying on the suffix of the URL to determine if we're on the right page to run that JS, is not going to work.
What we should probably do instead, is that when the block is being rendered on a page where that link should be Javascriptified, then we should add some inline JS that invokes the connectAnnotati
Changed in mahara: | |
status: | New → Confirmed |
importance: | Undecided → High |
assignee: | nobody → Ghada El-Zoghbi (ghada-z) |
milestone: | none → 15.04.0 |
tags: | added: annotations cleanurls smartevidence |
Changed in mahara: | |
assignee: | Ghada El-Zoghbi (ghada-z) → Aaron Wells (u-aaronw) |
tags: | added: regression |
Changed in mahara: | |
status: | Confirmed → In Progress |
Changed in mahara: | |
status: | In Progress → Fix Committed |
Changed in mahara: | |
status: | Fix Committed → Fix Released |
Patch for "master" branch: https:/ /reviews. mahara. org/4401