[data processing] After update to use "data-processing", no sahara panels show up

[Chad Roberts]

Recently, horizon was updated to use "data-processing" as the service type for Sahara. That change went through without updating the permissions checks in each panel. They are still using data_processing...

permissions = ('openstack.services.data-processing',)

Each panel needs to be updated to the following:

permissions = ('openstack.services.data_processing',)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/162736

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/162736
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=f4781d87966c9f1288d5c1898a1c6b4ac673c3d6
Submitter: Jenkins
Branch: master

commit f4781d87966c9f1288d5c1898a1c6b4ac673c3d6
Author: Chad Roberts <email address hidden>
Date: Mon Mar 9 15:32:13 2015 -0400

    Fixing permissions for data processing panels

    Recently, the data processing service was renamed to
    "data-processing" rather than "data_processing". Each
    panel needs to be updated so that it will show up when
    the data-processing service is enabled. Also updated
    the underlying test data to reflect the update.

    Change-Id: I38d7350215cbe5c5f406d75d6be7c9057957bc69
    Closes-Bug: #1429987

[David Lyle (david-lyle)]

Hopefully anyone who's already deployed sahara and registered it with the service catalog finds this update and makes the appropriate changes. Not sure just a full swap was the right answer.

[Lin Hua Cheng (lin-hua-cheng)]

You're right, maybe we should be updating the permission check to do an data-processing OR data_processing instead

[Chad Roberts (croberts)]

I agree that using an OR is probably the better way to go to be sure of backward compatibility. Perhaps I'm just being a bit dense here, but I'm not sure what that would look like code-wise. Suggestions?

----- Original Message -----
From: "Lin Hua Cheng" <email address hidden>
To: <email address hidden>
Sent: Tuesday, March 10, 2015 12:56:58 PM
Subject: [Bug 1429987] Re: [data processing] After update to use "data-processing", no sahara panels show up

You're right, maybe we should be updating the permission check to do an
data-processing OR data_processing instead

--
You received this bug notification because you are subscribed to the bug
report.
https://bugs.launchpad.net/bugs/1429987

Title:
  [data processing] After update to use "data-processing", no sahara
  panels show up

Status in OpenStack Dashboard (Horizon):
  Fix Committed

Bug description:
  Recently, horizon was updated to use "data-processing" as the service
  type for Sahara. That change went through without updating the
  permissions checks in each panel. They are still using
  data_processing...

  permissions = ('openstack.services.data-processing',)

  Each panel needs to be updated to the following:

  permissions = ('openstack.services.data_processing',)

To manage notifications about this bug go to:
https://bugs.launchpad.net/horizon/+bug/1429987/+subscriptions

[Chad Roberts (croberts)]

I agree that using an OR is probably the better way to go to be sure of backward compatibility. Perhaps I'm just being a bit dense here, but I'm not sure what that would look like code-wise. Suggestions?

[Lin Hua Cheng (lin-hua-cheng)]

Here is an example of panel using an OR permission:
https://github.com/openstack/horizon/blob/master/openstack_dashboard/dashboards/identity/projects/panel.py#L29-L30

[Lin Hua Cheng (lin-hua-cheng)]

We have to make the service-catalog lookup smarter too: to check first if data_processing is available before trying out data-processing

https://github.com/openstack/horizon/commit/8c4a2cd1265c86d3493b82cb9d1277a2274f63cf#diff-9f28a3f6402460cf88564d4e601dd9a7