Link underlining in skins doesn't work
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Mahara |
Fix Released
|
Medium
|
Unassigned | ||
1.10 |
Fix Released
|
Medium
|
Unassigned | ||
1.8 |
Fix Released
|
Medium
|
Unassigned | ||
1.9 |
Fix Released
|
Medium
|
Unassigned | ||
15.04 |
Fix Released
|
Medium
|
Unassigned | ||
15.10 |
Fix Released
|
Medium
|
Unassigned |
Bug Description
If the user edits a skin (Edit skin > Fonts and colours) and checks the Underline link -option, the link doesn't get underlined on a page with the skin applied. There seems to be a bug in skin/style.php#38 with the comparison
if ($option == 'transparent')
because when a checkbox is selected, the $option value is a boolean TRUE and when using PHP's loose comparison operator, (true == 'transparent') = true. Therefore for example $skin->
A simple fix is to use strict comparison:
if ($option === 'transparent')
---
Mahara version: 1.9.1
Browser: Chrome (Linux) 40.0.2214.115 (64-bit)
Changed in mahara: | |
status: | Fix Committed → Fix Released |
tags: | added: no-behat-needed |
Hi Olli,
Thanks for the bug report!
Cheers,
Aaron