Dell SC REST API removed option fails snapshot creation

[Tom Swanson]

The doNotExpire option was removed from the Dell SC REST API interface for snapshot creation. (expiretime == 0 does the same thing)

This fails snapshot creation with a 400 Bad Request error.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/161382

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/161382
Committed: https://git.openstack.org/cgit/openstack/cinder/commit/?id=db867c2032200070af87318b9cf39595006353ac
Submitter: Jenkins
Branch: master

commit db867c2032200070af87318b9cf39595006353ac
Author: Tom Swanson <email address hidden>
Date: Wed Mar 4 13:56:13 2015 -0600

    Dell SC API change fails snapshot creation

    The Dell Storage Center driver is failing snapshot creation on
    later versions of the Dell REST API.

    The doNotExpire option was removed in API 15.3.1.110. We were
    setting this so that the replays are not expired and removed when
    Cinder expects them to still be there. This has been replaced by
    setting expiretime to 0. We were doing this already so the fix
    was to simply remove doNotExpire from the REST request payload.

    This will fail on every future release of the Dell Storage Center
    so this is a critical fix.

    Closes-Bug 1428259

    Change-Id: I51fbf599e29e30793cdd1e6014e876d749732fd3