devel: vbox drivers introduce symlinks which prevent use of orig.tar.gz

Bug #1426113 reported by Andy Whitcroft
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
linux (Ubuntu)
Fix Released
High
Andy Whitcroft

Bug Description

The introduction of the vbox drivers prevent use of a .orig.tar.gz. Need to work out how to remove these and restore them on clean.

Tags: patch
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Andy Whitcroft (apw)
milestone: none → ubuntu-15.02
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
milestone: ubuntu-15.02 → ubuntu-15.03
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: Confirmed → In Progress
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: In Progress → Fix Committed
Revision history for this message
h (hparad) wrote :

when building kernel-sources with quilt i struggled about symlinks created
in other folders.
had to add:
index 18b765f..6e5caa8 100644
--- a/debian.master/reconstruct
+++ b/debian.master/reconstruct
@@ -4,3 +4,5 @@ ln -sf ../r0drv ubuntu/vbox/vboxguest/r0drv
 ln -sf ../include ubuntu/vbox/vboxsf/include
 ln -sf ../r0drv ubuntu/vbox/vboxsf/r0drv
 ln -sf ../include ubuntu/vbox/vboxvideo/include
+rm -f ubuntu/vbox/r0drv/r0drv
+rm -f ubuntu/vbox/include/include

Better way should be to check if symlink exist.

Date: Wed, 4 Mar 2015 17:53:22 +0100
Subject: [PATCH] ubuntu-vbox-guest-fix-symlinks

---
 debian.master/reconstruct | 20 +++++++++++++++-----
 1 file changed, 15 insertions(+), 5 deletions(-)

diff --git a/debian.master/reconstruct b/debian.master/reconstruct
index 18b765f..caba9b7 100644
--- a/debian.master/reconstruct
+++ b/debian.master/reconstruct
@@ -1,6 +1,16 @@
 # Reconstruct vbox symlinks (LP:1426113)
-ln -sf ../include ubuntu/vbox/vboxguest/include
-ln -sf ../r0drv ubuntu/vbox/vboxguest/r0drv
-ln -sf ../include ubuntu/vbox/vboxsf/include
-ln -sf ../r0drv ubuntu/vbox/vboxsf/r0drv
-ln -sf ../include ubuntu/vbox/vboxvideo/include
+if ! [ -e ubuntu/vbox/vboxguest/include ]; then
+ ln -sf ../include ubuntu/vbox/vboxguest/include
+fi
+if ! [ -e ubuntu/vbox/vboxguest/r0drv ]; then
+ ln -sf ../r0drv ubuntu/vbox/vboxguest/r0drv
+fi
+if ! [ -e ubuntu/vbox/vboxsf/include ]; then
+ ln -sf ../include ubuntu/vbox/vboxsf/include
+fi
+if ! [ -e ubuntu/vbox/vboxsf/r0drv ]; then
+ ln -sf ../r0drv ubuntu/vbox/vboxsf/r0drv
+fi
+if ! [ -e ubuntu/vbox/vboxvideo/include ]; then
+ ln -sf ../include ubuntu/vbox/vboxvideo/include
+fi
--
1.9.1

Changed in linux (Ubuntu):
status: Fix Committed → Incomplete
tags: added: patch
Andy Whitcroft (apw)
Changed in linux (Ubuntu):
status: Incomplete → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package linux - 3.19.0-8.8

---------------
linux (3.19.0-8.8) vivid; urgency=low

  [ Andy Whitcroft ]

  * ubuntu: vbox -- elide the new symlinks and reconstruct on clean:
    - LP: #1426113
  * rebase to stable v3.19.1

  [ John Johansen ]

  * SAUCE: (no-up): apparmor: fix mediation of fs unix sockets
    - LP: #1408833

  [ Leann Ogasawara ]

  * Release Tracking Bug
    - LP: #1429940

  [ Upstream Kernel Changes ]

  * xen: correct bug in p2m list initialization
  * net/mlx5_core: Fix configuration of log_uar_page_sz
    - LP: #1419938
  * tpm/ibmvtpm: Additional LE support for tpm_ibmvtpm_send
    - LP: #1420575
  * net/mlx4_core: Maintain a persistent memory for mlx4 device
    - LP: #1422481
  * net/mlx4_core: Set device configuration data to be persistent across
    reset
    - LP: #1422481
  * net/mlx4_core: Refactor the catas flow to work per device
    - LP: #1422481
  * net/mlx4_core: Enhance the catas flow to support device reset
    - LP: #1422481
  * net/mlx4_core: Activate reset flow upon fatal command cases
    - LP: #1422481
  * net/mlx4_core: Manage interface state for Reset flow cases
    - LP: #1422481
  * net/mlx4_core: Handle AER flow properly
    - LP: #1422481
  * net/mlx4_core: Enable device recovery flow with SRIOV
    - LP: #1422481
  * net/mlx4_core: Reset flow activation upon SRIOV fatal command cases
    - LP: #1422481
  * tg3: Hold tp->lock before calling tg3_halt() from tg3_init_one()
    - LP: #1428111
  * rebase to v3.19.1
    - LP: #1410704
    - LP: #1411193
    - LP: #1400215
 -- Leann Ogasawara <email address hidden> Mon, 09 Mar 2015 10:08:29 -0700

Changed in linux (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.