[nailgun] networks are lost when interface is deleted

[Aleksey Kasatkin]

Issue arrives this way:

1. Some networks are mapped to the node's NIC.
2. NIC is deleted from nailgun DB for some reason (e.g. it was removed from node).
3. All networks that were mapped to that NIC become unavailable for that node.

Currently, the only way for deployed nodes to return networks to the node is to edit nailgun DB.
For newly added nodes you can remove and re-add node to environment.

[Dmitry Pyzhov (dpyzhov)]

We should warn user about changes in node hardware before deployment and reset network checker status. We should not update our database in case of hardware changes after deployment.

[Nikolay Markov (nmarkov)]

What is desired behavior in this case? I think this may be even a separate feature.

[Aleksey Kasatkin (alekseyk-ru)]

1. After deployment - don't update nailgun DB - no HW changes accepted.
2. Before deployment - warn user that networks from removed NICs are moved or deleted. User should be able to reallocate such networks (via UI preferably). AFAIS, there are several options here:
a. move all networks to other NIC(s)
b. move them but keep available for allocation
c. delete them but allow to add again

See related bug https://bugs.launchpad.net/fuel/+bug/1425907

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/169012

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/169012
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e687e76d95925ca7f0e5bac19d451ff77dc89b20
Submitter: Jenkins
Branch: master

commit e687e76d95925ca7f0e5bac19d451ff77dc89b20
Author: Aleksey Kasatkin <email address hidden>
Date: Mon Mar 30 20:10:17 2015 +0300

    Allow node interfaces update if it's in 'discover' or 'error' state

    Node inferfaces update is allowed when node is in one of the following states:
    'discover', 'error'. It's locked for other node states.
    It's not locked on node creation, i.e. when node.nic_interfaces is empty yet.

    Partial-Bug: #1425901
    Closes-Bug: #1428776

    Change-Id: Icc60c432296c28e89d71b1fd0dd864870553a467

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/5.1
Review: https://review.openstack.org/170078

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/6.0
Review: https://review.openstack.org/170183

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170183
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=b37c553e063aefdcc8549b0388c343cc63ff52ab
Submitter: Jenkins
Branch: stable/6.0

commit b37c553e063aefdcc8549b0388c343cc63ff52ab
Author: Aleksey Kasatkin <email address hidden>
Date: Mon Mar 30 20:10:17 2015 +0300

    Allow node interfaces update if it's in 'discover' or 'error' state

    Node inferfaces update is allowed when node is in one of the following states:
    'discover', 'error'. It's locked for other node states.
    It's not locked on node creation, i.e. when node.nic_interfaces is empty yet.

    Closes-Bug: #1425901
    Closes-Bug: #1428776
    Change-Id: Icc60c432296c28e89d71b1fd0dd864870553a467

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/170078
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=661a4f9502d2e6101ed2f5eb995bb675e6c3b2c5
Submitter: Jenkins
Branch: stable/5.1

commit 661a4f9502d2e6101ed2f5eb995bb675e6c3b2c5
Author: Aleksey Kasatkin <email address hidden>
Date: Thu Apr 2 14:05:40 2015 +0300

    Allow node interfaces update if it's in 'discover' or 'error' state

    Node inferfaces update is allowed when node is in one of the following states:
    'discover', 'error'. It's locked for other node states.
    It's not locked on node creation, i.e. when node.nic_interfaces is empty yet.

    Closes-Bug: #1425901
    Closes-Bug: #1428776
    Change-Id: Icc60c432296c28e89d71b1fd0dd864870553a467