[nailgun] cannot reassign networks

[Aleksey Kasatkin]

When mapping of some networks is lost (e.g. https://bugs.launchpad.net/fuel/+bug/1425901 ) API does not allow to map networks back to node's interfaces. It only allows to remap networks which are mapped to node already.

The problem is in validator: https://github.com/stackforge/fuel-web/blob/master/nailgun/nailgun/api/v1/validators/network.py#L290
It should check against networks which can be available for node instead of networks which are on node currently.

[Nikolay Markov (nmarkov)]

I think we need to discuss the desired behaviour thoroughly and then stick to it. Not sure if it can fit in 6.1, though.

[Aleksey Kasatkin (alekseyk-ru)]

It is better be solved in 7.0 as adv-networking will make big impact on related stuff. Main cause of disappearing of interfaces is fixed in https://bugs.launchpad.net/fuel/+bug/1425901 so this issue is less painful now.

[Aleksey Kasatkin (alekseyk-ru)]

https://bugs.launchpad.net/fuel/+bug/1425901 was fixed and interfaces are not changeable during/after deployment. So, it is enough to re-add node into environment if interfaces changes on it has led to loss of assigned networks.

[Aleksey Kasatkin (alekseyk-ru)]

It is relevant in 7.0 only in case when network template is not in use.
Move to 8.0 as it's Medium and it has workaround.

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/222545

[Dmitry Pyzhov (dpyzhov)]

I'm not sure if we should backport the fix to 7.0-updates. Looks risky to me.

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/222545
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=e3207a9dff5b77590e5884460c28d4cd014cf9f8
Submitter: Jenkins
Branch: master

commit e3207a9dff5b77590e5884460c28d4cd014cf9f8
Author: Ivan Kliuk <email address hidden>
Date: Thu Sep 17 16:25:11 2015 +0300

    Refactor network availability for node check

    Code of NetAssignmentValidator.validate updated with additional check
    which determines whether networks in input data can be assigned to node.
    The decision is made upon availability of particular net for node group
    in which the node is included. The validation is meant to substitute
    another check that does the same yet uses already assigned to the node's
    nics networks which has produced errorful behavior in some cases (see
    the bug's description)

    Change-Id: I028b50e32d7bf1b9d02674b861e2e5ff24b4f2d5
    Closes-bug: #1425907

[ElenaRossokhina (esolomina)]

Verified on iso#570
[root@nailgun ~]# cat /etc/fuel/version.yaml
VERSION:
  feature_groups:
    - mirantis
  production: "docker"
  release: "8.0"
  api: "1.0"
  build_number: "570"
  build_id: "570"
  fuel-nailgun_sha: "558ca91a854cf29e395940c232911ffb851899c1"
  python-fuelclient_sha: "4f234669cfe88a9406f4e438b1e1f74f1ef484a5"
  fuel-agent_sha: "658be72c4b42d3e1436b86ac4567ab914bfb451b"
  fuel-nailgun-agent_sha: "b2bb466fd5bd92da614cdbd819d6999c510ebfb1"
  astute_sha: "b81577a5b7857c4be8748492bae1dec2fa89b446"
  fuel-library_sha: "c2a335b5b725f1b994f78d4c78723d29fa44685a"
  fuel-ostf_sha: "3bc76a63a9e7d195ff34eadc29552f4235fa6c52"
  fuel-mirror_sha: "fb45b80d7bee5899d931f926e5c9512e2b442749"
  fuelmenu_sha: "78ffc73065a9674b707c081d128cb7eea611474f"
  shotgun_sha: "63645dea384a37dde5c01d4f8905566978e5d906"
  network-checker_sha: "a43cf96cd9532f10794dce736350bf5bed350e9d"
  fuel-upgrade_sha: "616a7490ec7199f69759e97e42f9b97dfc87e85b"
  fuelmain_sha: "d605bcbabf315382d56d0ce8143458be67c53434"

Verification Scenario (after discussion with originator):
-bootstrap node and add it into cluster
-select network i/f with assigned network and shutdown it on the new node
-try to re-assign network from switched-off interface to another one
-turn i/f on and assign network to it