Sub navigation background color not used for sub navigation

Bug #1414474 reported by Kristina Hoeppner
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon
1.10
Fix Released
Medium
Robert Lyon
1.8
Fix Released
Medium
Robert Lyon
1.9
Fix Released
Medium
Robert Lyon

Bug Description

In Mahara 1.8 a change was introduced to the configurable theme that does not show the second level navigation in the "sub navigation background" color anymore. I attach a screenshot to illustrate it.

This change needs to be reverted back for 15.04 so that users of the configurable theme have the optimal theming possibilities available until we switch the CSS framework. If they cannot theme the second level navigation (except for the item in the top level navigation), they cannot implement their preferred colors correctly.

description: updated
description: updated
Revision history for this message
Kristina Hoeppner (kris-hoeppner) wrote :
tags: added: regression
Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.8_STABLE" branch: https://reviews.mahara.org/4209

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4210

Robert Lyon (robertl-9)
Changed in mahara:
status: Confirmed → In Progress
assignee: nobody → Robert Lyon (robertl-9)
Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4210
Committed: http://gitorious.org/mahara/mahara/commit/754944a658498c18b3bd32b39a6cda7189967469
Submitter: Son Nguyen (<email address hidden>)
Branch: master

commit 754944a658498c18b3bd32b39a6cda7189967469
Author: Robert Lyon <email address hidden>
Date: Mon Jan 26 09:56:12 2015 +1300

Fixing problem where custom subnav background not showing (Bug #1414474)

To test - create an institution and give it the custom theme.
Add user to institution and log in with that user.

Between each test you will need to re-save the institution so that the
custom theme data in the db gets updated by the template change.

Change-Id: I21d97c77896d872cbfc335473fbf510999b5187b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4209
Committed: http://gitorious.org/mahara/mahara/commit/c56a550fe34d0ecedb1d50edde37b8d7a0d4f5ca
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.8_STABLE

commit c56a550fe34d0ecedb1d50edde37b8d7a0d4f5ca
Author: Robert Lyon <email address hidden>
Date: Mon Jan 26 09:56:12 2015 +1300

Fixing problem where custom subnav background not showing (Bug #1414474)

To test - create an institution and give it the custom theme.
Add user to institution and log in with that user.

Change-Id: I21d97c77896d872cbfc335473fbf510999b5187b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "1.9_STABLE" branch: https://reviews.mahara.org/4214

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "1.10_STABLE" branch: https://reviews.mahara.org/4215

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4214
Committed: http://gitorious.org/mahara/mahara/commit/fa544b5ea8b7f40b8e37d8f4c23c74f2fbf15438
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.9_STABLE

commit fa544b5ea8b7f40b8e37d8f4c23c74f2fbf15438
Author: Robert Lyon <email address hidden>
Date: Mon Jan 26 09:56:12 2015 +1300

Fixing problem where custom subnav background not showing (Bug #1414474)

To test - create an institution and give it the custom theme.
Add user to institution and log in with that user.

Between each test you will need to re-save the institution so that the
custom theme data in the db gets updated by the template change.

Change-Id: I21d97c77896d872cbfc335473fbf510999b5187b
Signed-off-by: Robert Lyon <email address hidden>

Revision history for this message
Mahara Bot (dev-mahara) wrote :

Reviewed: https://reviews.mahara.org/4215
Committed: http://gitorious.org/mahara/mahara/commit/d16101de143d537721bdec3a84a735439e30f4c8
Submitter: Robert Lyon (<email address hidden>)
Branch: 1.10_STABLE

commit d16101de143d537721bdec3a84a735439e30f4c8
Author: Robert Lyon <email address hidden>
Date: Mon Jan 26 09:56:12 2015 +1300

Fixing problem where custom subnav background not showing (Bug #1414474)

To test - create an institution and give it the custom theme.
Add user to institution and log in with that user.

Between each test you will need to re-save the institution so that the
custom theme data in the db gets updated by the template change.

Change-Id: I21d97c77896d872cbfc335473fbf510999b5187b
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Bug attachments

Remote bug watches

Bug watches keep track of this bug in other bug trackers.