project/containers/forms.py imports containers/tables only for the wrap_delimiter function

Bug #1411806 reported by Rob Cresswell
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Dashboard (Horizon)
Fix Released
Low
Kamil Rykowski

Bug Description

openstack_dashboard/dashboards/project/containers/forms.py imports containers/tables.py just for the 'wrap_delimiter' function. This function should be moved to a new containers/utils.py, and then imported to both forms and tables.

Changed in horizon:
assignee: nobody → Rob Cresswell (robcresswell)
tags: added: low-hanging-fruit
Changed in horizon:
assignee: Rob Cresswell (robcresswell) → nobody
Changed in horizon:
assignee: nobody → Sumanth (avadhanisumanth1)
Changed in horizon:
assignee: Sumanth (avadhanisumanth1) → nobody
GB21 (geetika791)
Changed in horizon:
assignee: nobody → GB21 (geetika791)
Changed in horizon:
status: New → In Progress
Revision history for this message
Sanskar Jhanwar (sanskarjhanwar) wrote :

Hey GB21,
I would like to know if you are working on this bug, else I would be happy to do it.

Thanks.

Revision history for this message
GB21 (geetika791) wrote : Re: [Bug 1411806] Re: project/containers/forms.py imports containers/tables only for the wrap_delimiter function

Hello Sanskar jhanwar
The bug is in progress,and I am making changes everyday,as per the upcoming
reviews.
Thanks
Regards
Geetika Batra
On Feb 27, 2015 10:55 AM, "Sanskar Jhanwar" <email address hidden>
wrote:

> Hey GB21,
> I would like to know if you are working on this bug, else I would be happy
> to do it.
>
> Thanks.
>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/1411806
>
> Title:
> project/containers/forms.py imports containers/tables only for the
> wrap_delimiter function
>
> Status in OpenStack Dashboard (Horizon):
> In Progress
>
> Bug description:
> openstack_dashboard/dashboards/project/containers/forms.py imports
> containers/tables.py just for the 'wrap_delimiter' function. This
> function should be moved to a new containers/utils.py, and then
> imported to both forms and tables.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/horizon/+bug/1411806/+subscriptions
>

Revision history for this message
Rob Cresswell (robcresswell-deactivatedaccount) wrote :
Changed in horizon:
assignee: GB21 (geetika791) → Kamil Rykowski (kamil-rykowski)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to horizon (master)

Reviewed: https://review.openstack.org/157760
Committed: https://git.openstack.org/cgit/openstack/horizon/commit/?id=038963cb1205fd010d85540074fd014cbdf0545a
Submitter: Jenkins
Branch: master

commit 038963cb1205fd010d85540074fd014cbdf0545a
Author: Geetika Batra <email address hidden>
Date: Fri Feb 20 19:17:46 2015 +0530

    Change of path of wrap_delimiter function

    openstack_dashboard/dashboards/project/containers/forms.py imports
    containers/tables.py just for the 'wrap_delimiter' function.
    The wrap_delimiter function has been moved to a new containers/utils.py,
    and then imported to both forms and tables.It is done as per the
    instructions
    specified in the bug.

    Co-Authored-By: GB21 <email address hidden>
    Co-Authored-By: Kamil Rykowski <email address hidden>

    Closes-bug:1411806
    Change-Id: I0bd04b0e2b31fd1bf2235256f6741ea628104680

Changed in horizon:
status: In Progress → Fix Committed
Akihiro Motoki (amotoki)
Changed in horizon:
milestone: none → kilo-rc1
David Lyle (david-lyle)
Changed in horizon:
importance: Undecided → Low
Thierry Carrez (ttx)
Changed in horizon:
status: Fix Committed → Fix Released
Thierry Carrez (ttx)
Changed in horizon:
milestone: kilo-rc1 → 2015.1.0
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.