Repeating alarms appear disabled in clock app after it went off once

[Jean-Baptiste Lallement]

krillin #198

Repeating alarm is disabled after the first time it goes off.

Test Case:
1. Setup a repeating alarm (everyday from Monday to Friday for example) and enable it
2. Close the clock app
3. Wait until it goes off
4. Dismiss it (and wait maybe 1 min or 2 so indicator is updated with next occurrence)
5. Resume the device
6. Launch the clock app
7. Go the alarms and verify the status of the alarm

Actual Result:
The alarm is disabled but it shows in the indicator.
The next and next-next occurrences of the alarm are scheduled correctly.

Expected Result
Alarm is still enabled.

[Dave Morley (davmor2)]

STEPS TO TEST CLOCK APP OVER EDS:
1. Set a repeatable alarm as above
2. Mock the day change with the following (Supposing alarm 1 was Monday 09:20)
adb shell
sudo date -s "Tue Jan 20 09:19:00 2015"
<change the date as appropriate>
3. You will note that the alarm still goes off so eds has the data correctly in place only the alarms page displays that the alarm is disabled.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

I am not able to confirm this.

1. Set date to the past - 9am tuesday
2. Set alarm for every day at 9:10
Wait. Alarm goes off.
3. Set date to the past - 9am wednesday
Wait. Alarm goes off.

http://people.canonical.com/~alan/screenshots/device-2015-01-15-095449.png - alarm set
http://people.canonical.com/~alan/screenshots/device-2015-01-15-095459.png - showing in i-d
http://people.canonical.com/~alan/screenshots/device-2015-01-15-095521.png - showing "7 mins till alarm" in clock
(missing screenshot of alarm going off)
http://people.canonical.com/~alan/screenshots/device-2015-01-15-102141.png - i-d showing alarm for 'tomorrow'
http://people.canonical.com/~alan/screenshots/device-2015-01-15-102608.png - It's now 'tomorrow'
http://people.canonical.com/~alan/screenshots/device-2015-01-15-103543.png - alarm going off again

[Alan Pope 🍺🐧🐱 🦄 (popey)]

http://people.canonical.com/~alan/screenshots/device-2015-01-15-104018.png - alarm still shows 'enabled' in clock app.

[Alan Pope 🍺🐧🐱 🦄 (popey)]

Time passes, and now it shows disabled...
http://people.canonical.com/~alan/screenshots/device-2015-01-15-105126.png

[Nekhelesh Ramananthan (nik90)]

I suspect this is a side effect that was introduced while fixing https://bugs.launchpad.net/ubuntu-clock-app/+bug/1362341. Instead of disabling just one-time alarms after they ring, I presume indicator-datetime mistakingly disables recurring alarms as well. Clock app merely displays the EDS data and in this case it seems the EDS is being changed incorrectly.

[Jean-Baptiste Lallement (jibel)]

I downgraded to indicator-datetime 13.10.0+14.10.20141009-0ubuntu1 and cannot reproduce the problem

[Charles Kerr (charlesk)]

I suspect nik90's right about this being a regression introduced by bug #1362341.

Looking at the .ics file after running jibel's recipe, I see that the alarm's CATEGORIES entry includes the x-canonical-disabled tag.

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-datetime - 13.10.0+15.04.20150115~rtm-0ubuntu1

---------------
indicator-datetime (13.10.0+15.04.20150115~rtm-0ubuntu1) 14.09; urgency=low

  [ Charles Kerr ]
  * Fix bug that misidentified repeating alarms as one-time alarms,
    causing them to be disabled after triggering. (LP: #1411171)
 -- Ubuntu daily release <email address hidden> Thu, 15 Jan 2015 20:57:21 +0000

[Łukasz Zemczak (sil2100)]

I was just wondering: is this also causing issues in vivid as well? We have an Ubuntu task for this bug here and this change didn't land in vivid, which is a requirement in case of reproducibility.

[Nekhelesh Ramananthan (nik90)]

@lukasz, yeah this would also be affecting vivid. However at the moment the alarms feature in vivid is broken badly due to SDK Alarms API (alarms backend rewritten for performance and other benefits). Thereby it is difficult to identify if fixes like the above work or not. I would recommend waiting for the SDK Alarms API to settle down a bit in vivid before pushign this fix to vivid.

[Łukasz Zemczak (sil2100)]

Ok, so I'm leaving it on our issue list for Ubuntu until the situation gets cleared up - this way it will stay on our radar. Thanks!

[Launchpad Janitor (janitor)]

This bug was fixed in the package indicator-datetime - 13.10.0+15.04.20150127-0ubuntu1

---------------
indicator-datetime (13.10.0+15.04.20150127-0ubuntu1) vivid; urgency=low

  [ Charles Kerr ]
  * Fix bug that misidentified repeating alarms as one-time alarms,
    causing them to be disabled after triggering. (LP: #1411171)

  [ Ubuntu daily release ]
  * New rebuild forced
 -- Ubuntu daily release <email address hidden> Tue, 27 Jan 2015 00:24:00 +0000