Cluster attrubute use_vcenter value is always true

Bug #1410163 reported by Alexander Kislitsky
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Fuel for OpenStack
Fix Released
Medium
Igor Gajsin

Bug Description

Cluster attribute vcenter.use_vcenter is always True.

Tags: vcenter
Revision history for this message
Ihor Kalnytskyi (ikalnytskyi) wrote :

Is this really 6.0.1 specific? if not, we need to target to 6.1 also.

Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

This parameter is not in use, actually. Seems, it can be dropped from fixture. But its value is saved into stats snapshot. Let's drop it from snapshot then.

Changed in fuel:
status: Confirmed → Triaged
milestone: 6.0.1 → 6.1
Revision history for this message
Aleksey Kasatkin (alekseyk-ru) wrote :

Igor G. , please comment.

Changed in fuel:
assignee: Fuel Python Team (fuel-python) → Igor Gajsin (igajsin)
Igor Gajsin (igajsin)
tags: added: vcenter
Revision history for this message
Igor Zinovik (izinovik) wrote :

I think we can safely drop 'use_vcenter', it is not used in fuel-library/ puppet manifests. In manifests we rely on $::fuel_settings['libvirt_type'] = 'vcenter', not no 'use_vcenter' = true.

I checked against fuel-library/ master branch as of 15 Jan 2015.

Revision history for this message
Igor Gajsin (igajsin) wrote :

I agree. Commit will be sended to gerrit a little later.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-web (master)

Fix proposed to branch: master
Review: https://review.openstack.org/147484

Changed in fuel:
status: Triaged → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-web (master)

Reviewed: https://review.openstack.org/147484
Committed: https://git.openstack.org/cgit/stackforge/fuel-web/commit/?id=f858b6a703a86358b202cf11e405d18ce758f0cc
Submitter: Jenkins
Branch: master

commit f858b6a703a86358b202cf11e405d18ce758f0cc
Author: Igor Gajsin <email address hidden>
Date: Thu Jan 15 15:11:06 2015 +0300

    Remove useless attribute use_vcenter from openstack.yaml

    There is parameter use_vcenter in openstack.yaml file which always equal true
    and never used. This patch just remove unused parameter.

    Change-Id: Ifa91691516140861b33bfdb2c562481061834b62
    Closes-bug: #1410163

Changed in fuel:
status: In Progress → Fix Committed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to fuel-main (master)

Fix proposed to branch: master
Review: https://review.openstack.org/148220

Revision history for this message
Tatyana Dubyk (tdubyk) wrote :

Verified on 6.1 (#64 iso)

Changed in fuel:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to fuel-main (master)

Reviewed: https://review.openstack.org/148220
Committed: https://git.openstack.org/cgit/stackforge/fuel-main/commit/?id=bdbcc92b870af37dff2466348a0f2a392b73d1b0
Submitter: Jenkins
Branch: master

commit bdbcc92b870af37dff2466348a0f2a392b73d1b0
Author: Igor Zinovik <email address hidden>
Date: Mon Jan 19 14:22:55 2015 +0300

    Zap unused variable 'use_vcenter' that is no longer exist

    - system tests rely on non-existent variable 'use_vcenter', instead of
      relying on variable that is always set to true, tests must rely on
      hypervisor type
    - commit f858b6a703a86358b202cf11e405d18ce758f0cc in fuel-web/
      repository removed 'use_vcenter', justification for this can be found
      in bug #1410163

    Change-Id: I454697d7d160be4197abb5791b609948baf009bb

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.