Son says it's related to the adodb upgrade:
Test case on the latest master:
1. Create a group.
2. Write a forum post and submit it.
3. Get big error message.
----------------------------------------------------
[WAR] 82 (lib/errors.php:747) Failed to get a recordset: postgres8 error: [-2: ERROR: syntax error at or near "group"
LINE 1: SELECT group FROM "interaction_instance" WHERE "id" = $1
^] in EXECUTE("SELECT group FROM "interaction_instance" WHERE "id" = ? ")
Command was: SELECT group FROM "interaction_instance" WHERE "id" = ? and values was (1)
Call stack (most recent first):
log_message("Failed to get a recordset: postgres8 error: [-2: E...", 8, true, true) at /home/kristina/code/mahara/htdocs/lib/errors.php:97
log_warn("Failed to get a recordset: postgres8 error: [-2: E...") at /home/kristina/code/mahara/htdocs/lib/errors.php:747
SQLException->__construct("Failed to get a recordset: postgres8 error: [-2: E...") at /home/kristina/code/mahara/htdocs/lib/dml.php:477
get_recordset_sql("SELECT group FROM "interaction_instance" WHERE "i...", array(size 1)) at /home/kristina/code/mahara/htdocs/lib/dml.php:788
get_field_sql("SELECT group FROM "interaction_instance" WHERE "i...", array(size 1)) at /home/kristina/code/mahara/htdocs/lib/dml.php:776
get_field("interaction_instance", "group", "id", 1) at /home/kristina/code/mahara/htdocs/interaction/forum/edittopic.php:198
addtopic_submit(object(Pieform), array(size 9)) at Unknown:0
call_user_func_array("addtopic_submit", array(size 2)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:527
Pieform->__construct(array(size 4)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:162
Pieform::process(array(size 4)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 4)) at /home/kristina/code/mahara/htdocs/interaction/forum/edittopic.php:173
[WAR] 82 (lib/dml.php:477) Failed to get a recordset: postgres8 error: [-2: ERROR: syntax error at or near "group"
LINE 1: SELECT group FROM "interaction_instance" WHERE "id" = $1
^] in EXECUTE("SELECT group FROM "interaction_instance" WHERE "id" = ? ")
Command was: SELECT group FROM "interaction_instance" WHERE "id" = ? and values was (1)
Call stack (most recent first):
get_recordset_sql("SELECT group FROM "interaction_instance" WHERE "i...", array(size 1)) at /home/kristina/code/mahara/htdocs/lib/dml.php:788
get_field_sql("SELECT group FROM "interaction_instance" WHERE "i...", array(size 1)) at /home/kristina/code/mahara/htdocs/lib/dml.php:776
get_field("interaction_instance", "group", "id", 1) at /home/kristina/code/mahara/htdocs/interaction/forum/edittopic.php:198
addtopic_submit(object(Pieform), array(size 9)) at Unknown:0
call_user_func_array("addtopic_submit", array(size 2)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:527
Pieform->__construct(array(size 4)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:162
Pieform::process(array(size 4)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:71
pieform(array(size 4)) at /home/kristina/code/mahara/htdocs/interaction/forum/edittopic.php:173
[WAR] 82 (lib/form/elements/wysiwyg.php:87) Invalid argument supplied for foreach()
Call stack (most recent first):
log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/kristina/code/mahara/htdocs/lib/form/element...", 87) at /home/kristina/code/mahara/htdocs/lib/errors.php:441
error(2, "Invalid argument supplied for foreach()", "/home/kristina/code/mahara/htdocs/lib/form/element...", 87, array(size 2)) at /home/kristina/code/mahara/htdocs/lib/form/elements/wysiwyg.php:87
pieform_element_wysiwyg_get_headdata(array(size 8)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1732
pieform_get_headdata() at /home/kristina/code/mahara/htdocs/lib/web.php:92
smarty(array(size 0), array(size 0), array(size 0), array(size 1)) at /home/kristina/code/mahara/htdocs/lib/errors.php:576
MaharaException->handle_exception() at /home/kristina/code/mahara/htdocs/lib/errors.php:467
exception(object(SQLException)) at Unknown:0
[WAR] 82 (lib/form/elements/wysiwyg.php:94) Invalid argument supplied for foreach()
Call stack (most recent first):
log_message("Invalid argument supplied for foreach()", 8, true, true, "/home/kristina/code/mahara/htdocs/lib/form/element...", 94) at /home/kristina/code/mahara/htdocs/lib/errors.php:441
error(2, "Invalid argument supplied for foreach()", "/home/kristina/code/mahara/htdocs/lib/form/element...", 94, array(size 2)) at /home/kristina/code/mahara/htdocs/lib/form/elements/wysiwyg.php:94
pieform_element_wysiwyg_get_headdata(array(size 8)) at /home/kristina/code/mahara/htdocs/lib/pieforms/pieform.php:1732
pieform_get_headdata() at /home/kristina/code/mahara/htdocs/lib/web.php:92
smarty(array(size 0), array(size 0), array(size 0), array(size 1)) at /home/kristina/code/mahara/htdocs/lib/errors.php:576
MaharaException->handle_exception() at /home/kristina/code/mahara/htdocs/lib/errors.php:467
exception(object(SQLException)) at Unknown:0
Patch for "master" branch: https:/ /reviews. mahara. org/4116