Rbd backend doesn't support disk IO qos

Bug #1405367 reported by StephenSun
54
This bug affects 9 people
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Low
Daniel Berrange

Bug Description

Honor https://wiki.openstack.org/wiki/InstanceResourceQuota#IO_limits by propagating
the extra_specs also in the RBD sub-class.

Tags: ceph libvirt
StephenSun (stephen-3)
Changed in nova:
assignee: nobody → stephen (stephen-3)
StephenSun (stephen-3)
Changed in nova:
status: New → In Progress
StephenSun (stephen-3)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (master)

Fix proposed to branch: master
Review: https://review.openstack.org/143939

StephenSun (stephen-3)
description: updated
Changed in nova:
status: In Progress → Confirmed
Changed in nova:
status: Confirmed → In Progress
Changed in nova:
importance: Undecided → Low
Changed in nova:
assignee: StephenSun (stephen-3) → Daniel Berrange (berrange)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to nova (master)

Reviewed: https://review.openstack.org/143939
Committed: https://git.openstack.org/cgit/openstack/nova/commit/?id=fdb7b030abbff85d19581c3f2b0ba68683fd8d6f
Submitter: Jenkins
Branch: master

commit fdb7b030abbff85d19581c3f2b0ba68683fd8d6f
Author: StephenSun <email address hidden>
Date: Thu Dec 25 12:04:03 2014 +0800

    libvirt: fix disk I/O QOS support with RBD

    The disk I/O QOS settings were set in the libvirt_info
    method of the Image class. While this is fine for most
    subclasses, the Rbd subclass overrides this method and
    so was loosing the QOS settings. Move the setting of
    QOS parameters into a separate method so it can be
    called in all places that need it. For added fun the
    commit 86e6f34 which added QOS settings originally never
    added any unit tests to cover its operation.

    Co-authored: Daniel P. Berrange <email address hidden>
    Fixes bug #1405367
    Change-Id: Ibb3a4dff8996c29ef921be7c56648a442bbb89a2

Changed in nova:
status: In Progress → Fix Committed
Thierry Carrez (ttx)
Changed in nova:
milestone: none → liberty-3
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to nova (stable/kilo)

Fix proposed to branch: stable/kilo
Review: https://review.openstack.org/231925

tags: added: kilo-backport-potential
Thierry Carrez (ttx)
Changed in nova:
milestone: liberty-3 → 12.0.0
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on nova (stable/kilo)

Change abandoned by Francois Deppierraz (<email address hidden>) on branch: stable/kilo
Review: https://review.openstack.org/231925
Reason: Ok, let's abandon this backport.

Revision history for this message
Tony Breeds (o-tony) wrote :

Removed the kilo-backport-potential as the backport isn't appropriate for a "Phase II" Stable branch

tags: added: ceph libvirt
removed: kilo-backport-potential
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.