Switchbox pieform element doesn't work in block configs

Bug #1403703 reported by Aaron Wells
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mahara
Fix Released
Medium
Robert Lyon

Bug Description

I was doing some experimenting with the new switchbox pieform element, and I found that trying to put it in a block config causes the block config popup to error out.

The error in the Javascript console is:

"ERROR: sendjsonrequest() callback failed: TypeError: jQuery(...).switchButton is not a function [object Object]"

I believe this is because the switchbutton library isn't getting properly loaded if it's in a block config.

Revision history for this message
Mahara Bot (dev-mahara) wrote : A patch has been submitted for review

Patch for "master" branch: https://reviews.mahara.org/4107

Changed in mahara:
status: Confirmed → In Progress
Revision history for this message
Mahara Bot (dev-mahara) wrote :

Patch for "master" branch: https://reviews.mahara.org/4229

Revision history for this message
Mahara Bot (dev-mahara) wrote : A change has been merged

Reviewed: https://reviews.mahara.org/4107
Committed: http://gitorious.org/mahara/mahara/commit/3e4c4a9c6f67cbbb235e749d7766bb9b68c628a8
Submitter: Aaron Wells (<email address hidden>)
Branch: master

commit 3e4c4a9c6f67cbbb235e749d7766bb9b68c628a8
Author: Robert Lyon <email address hidden>
Date: Thu Jan 29 16:03:02 2015 +1300

Adjusting the switchbox to be css only (Bug #1403703)

And getting it to work in a block configuration form - see the image
block's configuration form

Includes reverting these commits
db7f45200020bc96f4250ee6498e95cd6d40814d
9e0c498c91f7e6c26635267c447e51a4fee4d2e9

and altering this commit to not use the switchbutton jquery plugin
901df0a558843b27f56d59937e67dee994f09545

Change-Id: I818c296cdcf573ede63b1783defb1b528d93ae2d
Signed-off-by: Robert Lyon <email address hidden>

Robert Lyon (robertl-9)
Changed in mahara:
status: In Progress → Fix Committed
Robert Lyon (robertl-9)
Changed in mahara:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.